This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat(core): add support for empty results and refresh indicator #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/GANMb36WyU9MWbiPxgDukbxoxmB5 |
villebro
force-pushed
the
villebro/refresh
branch
from
7d87b19
to
28a968a
Compare
villebro
force-pushed
the
villebro/refresh
branch
2 times, most recently
from
a6428e0
to
fccb805
Compare
villebro
force-pushed
the
villebro/refresh
branch
from
fccb805
to
0b6965e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 28.99% 29.02% +0.03%
==========================================
Files 462 462
Lines 9208 9212 +4
Branches 1452 1453 +1
==========================================
+ Hits 2670 2674 +4
Misses 6334 6334
Partials 204 204
Continue to review full report at Codecov.
|
kgabryje
approved these changes
May 18, 2021
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Add support for empty datasets without rendering the "No Results" placeholder text and an flag to notify the chart that it's refreshing data without being forced to use the default spinner. Needed to be able to add support for "Search all filter options" feature in Select Filter.
See below an example of the native select filter with the feature turned on (the chart loading times have been exaggerated by placing a sleep on the backend):
https://user-images.githubusercontent.com/33317356/118638272-5402ed00-b7df-11eb-9a2c-a9e78b297c63.mp4