Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: making location of sorting arrows in Table more consistent. #1124

Merged

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 19, 2021

💔 Breaking Changes

🏆 Enhancements

Before:

image

After:
image

📜 Documentation

🐛 Bug Fix

🏠 Internal
@junlincc

@rusackas rusackas requested a review from a team as a code owner May 19, 2021 17:31
@vercel
Copy link

vercel bot commented May 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/27w5xP8Zw7xHEpmAKckN2wxkA1Ut
✅ Preview: https://superset-ui-git-fork-preset-io-table-sort-arrow-reloc-f6f85d.vercel.app

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1124 (412a9b7) into master (07256ed) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   29.02%   29.06%   +0.03%     
==========================================
  Files         462      462              
  Lines        9213     9218       +5     
  Branches     1454     1454              
==========================================
+ Hits         2674     2679       +5     
  Misses       6334     6334              
  Partials      205      205              
Impacted Files Coverage Δ
plugins/plugin-chart-table/src/Styles.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07256ed...412a9b7. Read the comment docs.

@junlincc junlincc self-requested a review May 19, 2021 21:21
Copy link
Contributor

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as product sign-off. thank you for the improvement.

BEFORE:
Sort icon with different alignment positions in columns were confusing.
Screen Shot 2021-05-19 at 2 23 31 PM

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨Slick✨

@suddjian suddjian merged commit 2be365b into apache-superset:master May 20, 2021
@rusackas rusackas deleted the table-sort-arrow-relocation branch May 21, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants