Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(core): add support for case insensitive LIKE operator #1129

Merged
merged 1 commit into from
May 24, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro requested a review from a team as a code owner May 24, 2021 07:02
@vercel
Copy link

vercel bot commented May 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Eg7Fj1ZCg2LRfTJABVUKaXYzZ9hD
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-ilike-superset.vercel.app

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #1129 (07ba589) into master (3c24a78) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   29.04%   29.04%           
=======================================
  Files         462      462           
  Lines        9225     9225           
  Branches     1457     1457           
=======================================
  Hits         2679     2679           
  Misses       6341     6341           
  Partials      205      205           
Impacted Files Coverage Δ
...kages/superset-ui-core/src/query/types/Operator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c24a78...07ba589. Read the comment docs.

@villebro villebro merged commit ec301dc into apache-superset:master May 24, 2021
@villebro villebro deleted the villebro/ilike branch May 24, 2021 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants