Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-pivot-table): fix displaying column names when labels are available #1132

Merged
merged 1 commit into from
May 24, 2021

Conversation

kgabryje
Copy link
Contributor

@kgabryje kgabryje commented May 24, 2021

Fixes apache/superset#14716

In order to test this PR, link plugin-chart-pivot-table to Superset and create a Pivot Table chart with rows and columns which have labels assigned in dataset

Before:
image

After:
image

CC: @junlincc

@kgabryje kgabryje requested a review from a team as a code owner May 24, 2021 16:15
@vercel
Copy link

vercel bot commented May 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/3AignTBHtq8T1P4wr9u9yUaPsmfA
✅ Preview: https://superset-ui-git-fork-kgabryje-fix-pivot-table-labels-superset.vercel.app

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #1132 (bd53c25) into master (e7219ec) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   28.99%   28.98%   -0.01%     
==========================================
  Files         462      462              
  Lines        9261     9262       +1     
  Branches     1472     1473       +1     
==========================================
  Hits         2685     2685              
- Misses       6366     6367       +1     
  Partials      210      210              
Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <ø> (ø)
...gin-chart-pivot-table/src/plugin/transformProps.ts 71.42% <0.00%> (-11.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7219ec...bd53c25. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chart]Pivot Table v2 Labeling Issue
3 participants