Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: support sort the rich tooltip by metric desc[ID-6] #1445

Merged

Conversation

stephenLYZ
Copy link
Contributor

🏆 Enhancements
This PR adds one tooltip sort by metric control to support sorting the rich tooltip by metric desc.

not checked

image

checked

image

@stephenLYZ stephenLYZ requested a review from a team as a code owner October 28, 2021 18:43
@vercel
Copy link

vercel bot commented Oct 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/FYBcHm89Mq4fJDRpwSEyudGAghdK
✅ Preview: https://superset-ui-git-fork-stephenlyz-feat-tooltip-so-b7a1c4-superset.vercel.app

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #1445 (966f287) into master (8fcb8e9) will increase coverage by 0.01%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
+ Coverage   30.42%   30.43%   +0.01%     
==========================================
  Files         497      497              
  Lines       10003    10012       +9     
  Branches     1689     1691       +2     
==========================================
+ Hits         3043     3047       +4     
- Misses       6714     6719       +5     
  Partials      246      246              
Impacted Files Coverage Δ
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 80.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 50.00% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 50.00% <ø> (ø)
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 50.00% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 40.00% <ø> (ø)
...ugin-chart-echarts/src/Timeseries/controlPanel.tsx 40.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 53.75% <0.00%> (-1.38%) ⬇️
plugins/plugin-chart-echarts/src/controls.tsx 73.68% <80.00%> (+2.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcb8e9...966f287. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codes LGTM, please PM sign off. cc: @junlincc

@junlincc junlincc self-requested a review October 29, 2021 16:30
Copy link
Contributor

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better UX! Thanks for the improvement

@zhaoyongjie zhaoyongjie merged commit 02b7963 into apache-superset:master Oct 29, 2021
@stephenLYZ stephenLYZ changed the title feat: support sort the rich tooltip by metric desc feat: support sort the rich tooltip by metric desc[ID-6] Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants