Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: bump pretty-ms #398

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

villebro
Copy link
Contributor

🐛 Bug Fix

Bump pretty-ms dependency to fix rounding inconsistencies/errors in version 6: sindresorhus/pretty-ms#49

@villebro villebro requested a review from a team as a code owner April 28, 2020 07:12
@vercel
Copy link

vercel bot commented Apr 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2h97zhcww
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-bump-pretty-ms.superset.now.sh

@vercel vercel bot temporarily deployed to Preview April 28, 2020 07:12 Inactive
@vercel vercel bot temporarily deployed to Preview April 28, 2020 07:19 Inactive
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   24.63%   24.63%           
=======================================
  Files         239      239           
  Lines        5747     5747           
  Branches      581      581           
=======================================
  Hits         1416     1416           
  Misses       4294     4294           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3fe61...d90eaad. Read the comment docs.

@kristw kristw merged commit 771cf20 into apache-superset:master Apr 28, 2020
suddjian pushed a commit to suddjian/superset-ui that referenced this pull request Apr 29, 2020
)

* fix(legacy-table): container height on tall headers

* fix(legacy-table): possible undefined lint error
@ktmud
Copy link
Contributor

ktmud commented Apr 29, 2020

Better bump yarn.lock at the same time so that the actual upgrade doesn't happen in a random PR like this: https://github.com/apache-superset/superset-ui/pull/412/files#diff-8ee2343978836a779dc9f8d6b794c3b2

@villebro
Copy link
Contributor Author

Thanks @ktmud for the heads up, will keep this in mind next time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants