Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): remove columns from formData #901

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Jan 15, 2021

🐛 Bug Fix
Make sure columns property isn't defined in formData, as it is a reserved parameter with a specific meaning in QueryObject.

@villebro villebro requested a review from a team as a code owner January 15, 2021 18:49
@vercel
Copy link

vercel bot commented Jan 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/nax70ln5k
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-fix-boxplot.superset.now.sh

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man... LGTM! Let me know if you need help carrying it across to Superset.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #901 (47f48f2) into master (2d87d6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #901   +/-   ##
=======================================
  Coverage   26.66%   26.66%           
=======================================
  Files         405      405           
  Lines        8258     8258           
  Branches     1127     1127           
=======================================
  Hits         2202     2202           
  Misses       5927     5927           
  Partials      129      129           
Impacted Files Coverage Δ
...ins/plugin-chart-echarts/src/BoxPlot/buildQuery.ts 43.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d87d6f...47f48f2. Read the comment docs.

@ktmud
Copy link
Contributor

ktmud commented Jan 15, 2021

@ktmud
Copy link
Contributor

ktmud commented Jan 15, 2021

This change is good, but it may need to be updated soon after I deprecate groupby in #889

@ktmud ktmud merged commit 52ab338 into apache-superset:master Jan 15, 2021
@villebro villebro deleted the villebro/fix-boxplot branch January 15, 2021 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants