Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): label type and hover bugs #942

Merged
merged 2 commits into from
Feb 8, 2021
Merged

fix(plugin-chart-echarts): label type and hover bugs #942

merged 2 commits into from
Feb 8, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Feb 7, 2021 •
edited
Loading

🐛 Bug Fix

Bump ECharts to 5.0.2 to fix hover bug (apache/echarts#14108) and label type bug. Also clean up control panel so that all customization fields are on a single row.

After

image

Before

image

@villebro villebro requested a review from a team as a code owner February 7, 2021 11:51
@vercel
Copy link

vercel bot commented Feb 7, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/re0u9zlwv
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-echarts-502.superset.vercel.app

@codecov
Copy link

codecov bot commented Feb 7, 2021 •
edited
Loading

Codecov Report

Merging #942 (355d837) into master (52e355f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   27.49%   27.48%   -0.01%     
==========================================
  Files         412      412              
  Lines        8310     8309       -1     
  Branches     1149     1149              
==========================================
- Hits         2285     2284       -1     
  Misses       5891     5891              
  Partials      134      134
Impacted Files Coverage Δ
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e355f...355d837. Read the comment docs.

@villebro villebro mentioned this pull request Feb 7, 2021
Closed
3 tasks
@villebro villebro changed the title fix(plugin-chart-echarts): bump to 5.0.2 to fix incorrect label hide fix(plugin-chart-echarts): label type and hover bugs Feb 7, 2021
ktmud
ktmud approved these changes Feb 7, 2021
View reviewed changes
plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx
// eslint-disable-next-line react/jsx-key
[<h1 className="section-header">{t('Labels')}</h1>],
[
{
name: 'pie_label_type',
name: 'label_type',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does renaming this field matter here? Would you need a db migration for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need a migration - I'll add one to the bump PR.

@junlincc junlincc merged commit ca2d2f5 into apache-superset:master Feb 8, 2021
@villebro villebro deleted the villebro/echarts-502 branch February 8, 2021 07:29
@ktmud
Copy link
Contributor

ktmud commented Feb 10, 2021

Linking related db migration PR: https://github.com/apache/superset/pull/13052/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ktmud ktmud ktmud approved these changes

Assignees
No one assigned
Labels
next-release size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villebro @ktmud @junlincc