Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(chart-controls): expose datasource for some controls #969

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Feb 20, 2021

🏠 Internal

Expose current datasource to the state of adhoc_filters and time_range control and clean up the provideFormDataToProps option. We should just be explicit what prop to expose in mapStateToProps so controls don't get unnecessarily re-rendered because of form data updates from other unrelated controls.

superset-frontend has some related changes: apache/superset#13221

Test Plan

Manual verification in Superset via npm link:

  • Make sure both controls still work
  • Make sure changing dataset will reset time filter to default value ("Last week")

@ktmud ktmud requested a review from a team as a code owner February 20, 2021 02:10
@vercel
Copy link

vercel bot commented Feb 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/jhr9fyk5n
✅ Preview: https://superset-ui-git-expose-datasource.superset.now.sh

@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #969 (f96de7e) into master (cb01eec) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage   28.05%   28.04%   -0.01%     
==========================================
  Files         408      408              
  Lines        8342     8343       +1     
  Branches     1165     1166       +1     
==========================================
  Hits         2340     2340              
- Misses       5858     5859       +1     
  Partials      144      144              
Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 44.31% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb01eec...f96de7e. Read the comment docs.

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud ktmud merged commit bd4d592 into master Feb 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the expose-datasource branch February 22, 2021 09:55
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants