This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(chart-controls): expose datasource for some controls #969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
Expose current
datasource
to the state ofadhoc_filters
andtime_range
control and clean up theprovideFormDataToProps
option. We should just be explicit what prop to expose inmapStateToProps
so controls don't get unnecessarily re-rendered because of form data updates from other unrelated controls.superset-frontend
has some related changes: apache/superset#13221Test Plan
Manual verification in Superset via npm link: