-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Code hygiene #1222
base: main
Are you sure you want to change the base?
[Misc] Code hygiene #1222
Conversation
kenliao94
commented
May 13, 2024
•
edited
Loading
edited
- Rewrote some for-loop for cleaner code.
- Removed one of the unused import.
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of varying changes here. Not sure it makes sense as a single commit. Perhaps the iteration Java-language updates go as one easy commit.
I do not see a reason to remove null checks.
Is this PR part of a JIRA or NO-JIRA change?
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java
Outdated
Show resolved
Hide resolved
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java
Outdated
Show resolved
Hide resolved
This is part of a NO-JIRA change. I am just trying to clean up the code as I navigate the code :) I moved the removing redundant null checks from this PR to another I will create later to make this PR more about trivial updates. |
Hey Matt and JB, are there any more concerns about this PR? I checked the Jenkins failing tests they are about KahaDB [INFO] ActiveMQ ........................................... SUCCESS [ 0.852 s] [INFO] ActiveMQ :: BOM .................................... SUCCESS [ 0.248 s] [INFO] ActiveMQ :: Openwire Generator ..................... SUCCESS [ 1.091 s] [INFO] ActiveMQ :: Client ................................. SUCCESS [02:50 min] [INFO] ActiveMQ :: Openwire Legacy Support ................ SUCCESS [ 2.411 s] [INFO] ActiveMQ :: JAAS ................................... SUCCESS [01:46 min] [INFO] ActiveMQ :: Broker ................................. SUCCESS [01:18 min] [INFO] ActiveMQ :: KahaDB Store ........................... FAILURE [ 03:30 h] And the broker tests passed. |
I did a new pass and it looks good to me. If @mattrpav is OK (as he requested a change), I will merge it. |