AMQ-9544 Deprecated WildcardFileFilter constructor #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably need to re-run the tests. It seems to fail due to flakiness. |
pa-deasy
force-pushed
the
AMQ-9544-wildcardfilefilter-deprecated
branch
from
6e06a6e
to
cdce20a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problems does this PR solve?
As per the WildcardFileFilter docs the
WildcardFileFilter(String wildcard)constructor is deprecated. Replace this constructor with the recommended Builder.Why is it beneficial to merge into ActiveMQ?
Updates deprecated code with the recommended approach.
How do you make sure this PR is well tested?
Ran all of the tests that were updated to ensure they are still passing.
For abstract test classes, tested the classes which extend them.