-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Deprecate *args and **kwargs in BaseOperator
BaseOperator silently accepts any arguments. This deprecates the behavior with a warning that says it will be forbidden in Airflow 2.0. This PR also turns on DeprecationWarnings by default, which in turn revealed that inspect.getargspec is deprecated. Here it is replaced by `inspect.signature` (Python 3) or `funcsigs.signature` (Python 2). Lastly, this brought to attention that example_http_operator was passing an illegal argument.
- Loading branch information
1 parent
86f3463
commit 10ee622
Showing
7 changed files
with
66 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,24 @@ | ||
# Updating Airflow | ||
|
||
This file aims to document the backwards-incompatible changes in Airflow and | ||
assist people with migrating to a new version. | ||
This file documents any backwards-incompatible changes in Airflow and | ||
assists people when migrating to a new version. | ||
|
||
## 1.7 to 1.8 | ||
|
||
### DAGs now don't start automatically when created | ||
## Airflow 1.8 | ||
|
||
To retain the old behavior, add this to your configuration: | ||
### Changes to Behavior | ||
|
||
#### New DAGs are paused by default | ||
|
||
Previously, new DAGs would be scheduled immediately. To retain the old behavior, add this to airflow.cfg: | ||
|
||
``` | ||
[core] | ||
dags_are_paused_at_creation = False | ||
``` | ||
|
||
### Deprecated Features | ||
These features are marked for deprecation. They may still work (and raise a `DeprecationWarning`), but are no longer supported and will be removed entirely in Airflow 2.0 | ||
|
||
#### Operators no longer accept arbitrary arguments | ||
Previously, `Operator.__init__()` accepted any arguments (either positional `*args` or keyword `**kwargs`) without complaint. Now, invalid arguments will be rejected. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10ee622
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Can someone please help me understand this change? I see that all operators are calling
super
with*args
and**kwars
but I am seeing the warning only inQuboleOperator
? Also what is best way to avoid this warning.Thanks,
Sumit