Skip to content

Commit

Permalink
misc: add comment about remove unused code (#39748)
Browse files Browse the repository at this point in the history
* misc: add comment about remove unused code

* Update airflow/providers/amazon/aws/executors/ecs/ecs_executor.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

* Update airflow/providers/celery/executors/celery_executor.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

---------

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
  • Loading branch information
eladkal and pankajkoti authored May 22, 2024
1 parent cb57a67 commit 7b588b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions airflow/providers/amazon/aws/executors/ecs/ecs_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,7 @@ def attempt_task_runs(self):
except AttributeError:
# running_state is newly added, and only needed to support task adoption (an optional
# executor feature).
# TODO: remove when min airflow version >= 2.9.2
pass
if failure_reasons:
self.log.error(
Expand Down
1 change: 1 addition & 0 deletions airflow/providers/celery/executors/celery_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ def change_state(
super().change_state(key, state, info, remove_running=remove_running)
except AttributeError:
# Earlier versions of the BaseExecutor don't accept the remove_running parameter for this method
# TODO: Remove when min airflow version >= 2.9.2
super().change_state(key, state, info)
self.tasks.pop(key, None)

Expand Down

0 comments on commit 7b588b4

Please sign in to comment.