Skip to content

Commit

Permalink
Remove Tableau from Salesforce provider (#23747)
Browse files Browse the repository at this point in the history
* Remove Tableau from Salesforce provider
Tableau was split from Salesforce provider a year+ ago in #14030
We kept Tableau in Salesforce to preserve backward compatibility, it's time to remove the deprecated dependency.
  • Loading branch information
eladkal authored Jul 3, 2022
1 parent f1a9a9e commit 9c99552
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 139 deletions.
11 changes: 11 additions & 0 deletions airflow/providers/salesforce/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@
Changelog
---------

5.0.0
.....

Breaking changes
~~~~~~~~~~~~~~~~

* ``Remove Tableau from Salesforce provider (#23747)``

.. warning:: Due to tableau extra removal, ``pip install apache-airflow-providers-salesforce[tableau]``
will not work. You can install Tableau provider directly via ``pip install apache-airflow-providers-tableau``.

4.0.0
.....

Expand Down
26 changes: 0 additions & 26 deletions airflow/providers/salesforce/hooks/tableau.py

This file was deleted.

28 changes: 0 additions & 28 deletions airflow/providers/salesforce/operators/tableau_refresh_workbook.py

This file was deleted.

10 changes: 0 additions & 10 deletions airflow/providers/salesforce/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ versions:
dependencies:
- apache-airflow>=2.2.0
- simple-salesforce>=1.0.0
- tableauserverclient
- pandas>=0.17.1

integrations:
Expand All @@ -54,17 +53,8 @@ operators:
- integration-name: Salesforce
python-modules:
- airflow.providers.salesforce.operators.salesforce_apex_rest
- airflow.providers.salesforce.operators.tableau_refresh_workbook

sensors:
- integration-name: Salesforce
python-modules:
- airflow.providers.salesforce.sensors.tableau_job_status

hooks:
- integration-name: Tableau
python-modules:
- airflow.providers.salesforce.hooks.tableau
- integration-name: Salesforce
python-modules:
- airflow.providers.salesforce.hooks.salesforce
Expand Down
16 changes: 0 additions & 16 deletions airflow/providers/salesforce/sensors/__init__.py

This file was deleted.

29 changes: 0 additions & 29 deletions airflow/providers/salesforce/sensors/tableau_job_status.py

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@


warnings.warn(
"""This operator is deprecated. Please use `airflow.providers.tableau.operators.tableau`.""",
"This module is deprecated. Please use `airflow.providers.tableau.operators.tableau`.",
DeprecationWarning,
stacklevel=2,
)
Expand Down
20 changes: 0 additions & 20 deletions docs/apache-airflow-providers-salesforce/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -89,28 +89,8 @@ PIP package Version required
``apache-airflow`` ``>=2.2.0``
``pandas`` ``>=0.17.1``
``simple-salesforce`` ``>=1.0.0``
``tableauserverclient``
======================= ==================

Cross provider package dependencies
-----------------------------------

Those are dependencies that might be needed in order to use all the features of the package.
You need to install the specified provider packages in order to use them.

You can install such cross-provider dependencies when installing from PyPI. For example:

.. code-block:: bash
pip install apache-airflow-providers-salesforce[tableau]
====================================================================================================== ===========
Dependent package Extra
====================================================================================================== ===========
`apache-airflow-providers-tableau <https://airflow.apache.org/docs/apache-airflow-providers-tableau>`_ ``tableau``
====================================================================================================== ===========

Downloading official packages
-----------------------------

Expand Down
7 changes: 2 additions & 5 deletions generated/provider_dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -551,12 +551,9 @@
"deps": [
"apache-airflow>=2.2.0",
"pandas>=0.17.1",
"simple-salesforce>=1.0.0",
"tableauserverclient"
"simple-salesforce>=1.0.0"
],
"cross-providers-deps": [
"tableau"
]
"cross-providers-deps": []
},
"samba": {
"deps": [
Expand Down
5 changes: 1 addition & 4 deletions scripts/in_container/verify_providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ class ProviderPackageDetails(NamedTuple):
" for alternative uses",
"hdfs",
),
("This operator is deprecated. Please use `airflow.providers.tableau.operators.tableau`.", "salesforce"),
(
"You have an incompatible version of 'pyarrow' installed (4.0.1), please install a version that"
" adheres to: 'pyarrow<3.1.0,>=3.0.0; extra == \"pandas\"'",
Expand Down Expand Up @@ -211,9 +210,7 @@ class ProviderPackageDetails(NamedTuple):
"This module is deprecated. Please use `airflow.providers.microsoft.azure.sensors.cosmos`.",
"This module is deprecated. Please use `airflow.providers.amazon.aws.hooks.dynamodb`.",
"This module is deprecated. Please use `airflow.providers.microsoft.azure.transfers.local_to_wasb`.",
"This module is deprecated. Please use `airflow.providers.tableau.operators.tableau_refresh_workbook`.",
"This module is deprecated. Please use `airflow.providers.tableau.sensors.tableau_job_status`.",
"This module is deprecated. Please use `airflow.providers.tableau.hooks.tableau`.",
"This module is deprecated. Please use `airflow.providers.tableau.operators.tableau`.",
"This module is deprecated. Please use `kubernetes.client.models.V1Volume`.",
"This module is deprecated. Please use `kubernetes.client.models.V1VolumeMount`.",
(
Expand Down

0 comments on commit 9c99552

Please sign in to comment.