Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move relevant information from Commiter's guide to CONTRIBUTING.rst #10179

Closed
potiuk opened this issue Aug 5, 2020 · 2 comments · Fixed by #11314
Closed

Move relevant information from Commiter's guide to CONTRIBUTING.rst #10179

potiuk opened this issue Aug 5, 2020 · 2 comments · Fixed by #11314
Labels
good first issue kind:documentation

Comments

@potiuk
Copy link
Member

potiuk commented Aug 5, 2020 •
edited
Loading

Description

The old documentation for Commiter's guide should be reviewed and incorporated in CONTRIBUTING.rst

Use case / motivation

To remove documentation duplication and clean it up.

Related Issues

#10178
@potiuk potiuk added kind:feature Feature Requests good first issue kind:documentation and removed kind:feature Feature Requests labels Aug 5, 2020
@potiuk potiuk mentioned this issue Aug 5, 2020
Closed
11 tasks
@mik-laj
Copy link
Member

mik-laj commented Aug 6, 2020

I think, we should move it to the "dev" part of the Airflow Repo. The CONTRIBUTING.rst file is for new contributors and is already quite long. I don't think we should extend it, but try to make it more accessible to new people.

@potiuk potiuk changed the title Move relevant information from Commiter's guide to CONTRIBUTING.rst Move relevant information from Commiter's guide to dev Aug 6, 2020
@potiuk potiuk mentioned this issue Oct 6, 2020
Merged
@potiuk potiuk changed the title Move relevant information from Commiter's guide to dev Move relevant information from Commiter's guide to CONTRIBUTING.rst Oct 6, 2020
@potiuk
Copy link
Member Author

potiuk commented Oct 6, 2020

I reviewed it and decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.

potiuk added a commit to PolideaInternal/airflow that referenced this issue Oct 7, 2020
@potiuk
Moves Commiter's guide to CONTRIBUTING.rst
bd18ce2 
I decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.

Fixes: apache#10179
potiuk added a commit that referenced this issue Oct 7, 2020
@potiuk
Moves Commiter's guide to CONTRIBUTING.rst (#11314)
d404cb0 
I decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.

Fixes: #10179
potiuk added a commit that referenced this issue Nov 14, 2020
@potiuk
Moves Commiter's guide to CONTRIBUTING.rst (#11314)
b0a9436 
I decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.

Fixes: #10179
(cherry picked from commit d404cb0)
potiuk added a commit that referenced this issue Nov 16, 2020
@potiuk
Moves Commiter's guide to CONTRIBUTING.rst (#11314)
975866b 
I decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.

Fixes: #10179
(cherry picked from commit d404cb0)
kaxil pushed a commit that referenced this issue Nov 18, 2020
@potiuk @kaxil
Moves Commiter's guide to CONTRIBUTING.rst (#11314)
ae99892 
I decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.

Fixes: #10179
(cherry picked from commit d404cb0)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this issue Mar 5, 2021
@potiuk
Moves Commiter's guide to CONTRIBUTING.rst (apache#11314)
41f60b0 
I decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.

Fixes: apache#10179
(cherry picked from commit d404cb0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moves Commiter's guide to CONTRIBUTING.rst PolideaInternal/airflow
2 participants
@potiuk @mik-laj