Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve parameter name for SqlSensor, BaseSqlOperator, Connection #19638

Closed
2 tasks done
kazanzhy opened this issue Nov 17, 2021 · 1 comment · Fixed by #19849
Closed
2 tasks done

Resolve parameter name for SqlSensor, BaseSqlOperator, Connection #19638

kazanzhy opened this issue Nov 17, 2021 · 1 comment · Fixed by #19849
Assignees
Labels
kind:task A task that needs to be completed as part of a larger issue
Milestone

Comments

@kazanzhy
Copy link
Contributor

kazanzhy commented Nov 17, 2021

Apache Airflow version

2.2.2 (latest released)

Operating System

Ubuntu

Deployment

Virtualenv installation

What happened

There are different names for the same keyword argument:
BaseSqlOperator(hook_params) - by PR #18718
Connection.get_hook(hook_kwargs) - by PR #18718
SqlSensor(hook_params) - by PR #18431

Plan:

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@kazanzhy kazanzhy added area:core kind:bug This is a clearly a bug labels Nov 17, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 17, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@uranusjr uranusjr added kind:task A task that needs to be completed as part of a larger issue and removed kind:bug This is a clearly a bug area:core labels Nov 17, 2021
@uranusjr uranusjr added this to the Airflow 2.3.0 milestone Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants