Rename Connection.get_hook parameter to make it the same as in SqlSe… #19849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsor and SqlOperator.
boring-cyborg
bot
added
the
area:core-operators
kazanzhy
changed the title
|
Backward compatibility is not an issue since #18718 has not been released. |
uranusjr
approved these changes
Nov 27, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Oh yeah . Just checked the very thing too :) |
potiuk
approved these changes
Nov 27, 2021
dillonjohnson
pushed a commit
to dillonjohnson/airflow
that referenced
this pull request
Dec 1, 2021
…nsor and SqlOperator. (apache#19849)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
Connection.get_hookparameter from hook_kwargs to hook_params to make it the same as in SqlSensor(hook_params) and SqlOperator(hook_params).closes: #19638