Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0) #24421

Closed
2 tasks done
arminnajafi opened this issue Jun 13, 2022 · 9 comments · Fixed by #25689
Closed
2 tasks done
Assignees
Labels
area:dependencies Issues related to dependencies problems

Comments

@arminnajafi
Copy link

Apache Airflow version

2.3.2 (latest released)

What happened

Hello Airflow is pinning old version of attrs and this is leading to version conflict on our side to use Airflow.

And because every version of aws-cdk-lib requires attrs (>=21.2,<22.0) or jsii (>=1.58.0,<2.0.0) (4), every version of aws-cdk-lib requires attrs (>=21.2,<22.0)
      Because no versions of apache-airflow match >2.3.2,<3.0.0
   and apache-airflow (2.3.2) depends on attrs (>=20.0,<21.0), apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0).
      Thus, apache-airflow (>=2.3.2,<3.0.0) is incompatible with aws-cdk-lib.

What you think should happen instead

Please upgrade attrs to >=21

How to reproduce

No response

Operating System

macOS Monterey - 12.3.1

Versions of Apache Airflow Providers

No response

Deployment

Virtualenv installation

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@arminnajafi arminnajafi added area:core kind:bug This is a clearly a bug labels Jun 13, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 13, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

@arminnajafi arminnajafi changed the title Airflow pining old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0) Airflow pinning old version of attrs: apache-airflow (>=2.3.2,<3.0.0) requires attrs (>=20.0,<21.0) Jun 13, 2022
@potiuk
Copy link
Member

potiuk commented Jun 13, 2022

Feel free to PR it. - just remove the lmit frmo setup.cfg and solve any problems it might generate..

@potiuk
Copy link
Member

potiuk commented Jun 13, 2022

Assigned it to you

@arminnajafi
Copy link
Author

@potiuk
Thanks.

Any guidelines/pointers on how to get my environment set up and make sure tests pass after my changes?

I assume I just need to follow https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst ?

@potiuk
Copy link
Member

potiuk commented Jun 13, 2022

Yes/ Follow those.. CI will run all the tests as well when you push a change to setup.cfg. Updating requirements is a little more involved (You need to build image with --upgrade-to-newer-dependencies flag if you change dependencies and want to re-run test locally using breeze. This is the only difference vs. standard contribution guildelines.

@potiuk
Copy link
Member

potiuk commented Jun 13, 2022

There might be also other dependencies holding it back, so you need to check which versions you get when you build the image

@uranusjr
Copy link
Member

Also note that the setup.cfg contains some reasoning:

    # We limit the version of attrs to work with the old version of cattrs
    attrs>=20.0,<21.0
    # Cattrs upgrades were known to break lineage https://github.com/apache/airflow/issues/16172
    # TODO: Cattrs is now at 3.8 version so we should attempt to upgrade cattrs soon.
    cattrs~=1.1, !=1.7.*

You can use git blame to find the corresponding issues that added these comments. They provide context for you to evaluate whether upgrades are viable, and how they can be done.

@uranusjr uranusjr added area:dependencies Issues related to dependencies problems and removed kind:bug This is a clearly a bug area:core labels Jun 14, 2022
@potiuk
Copy link
Member

potiuk commented Jun 19, 2022

Any news @arminnajafi ?

@tomsej
Copy link
Contributor

tomsej commented Aug 16, 2022

Think this can be closed. See #25689

@potiuk potiuk linked a pull request Aug 16, 2022 that will close this issue
@potiuk potiuk closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Issues related to dependencies problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants