-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cattrs version #25689
Bump cattrs version #25689
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, but haven't checked anything in detail here.
Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in python-attrs/cattrs#151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything. Build is failing but it seems to be unrelated to my changes. Is there anything I can do to move it forward? |
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!) |
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ? |
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that 🤷 numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
to:
But I will try to get rid of it completely in parallel anyway |
Ah noo.... numpy==1.19.4 :...... This is strange. |
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer. |
Yeah. Lookiung at it |
This is a more complex issue - looks like |
Ohh, thanks a lot! Let me know if I can help... |
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :) |
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
Do I need to rerun the tests? Dziękuję bardzo :) |
I re-run it :) |
Awesome work, congrats on your first merged pull request! |
Co-authored-by: Radek Tomšej <radek.tomsej@almamedia.com> (cherry picked from commit c0e637a)
related: #24421
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.