Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a compatibility with Opensearch search for log management #33619

Closed
1 of 2 tasks
djadeau opened this issue Aug 22, 2023 · 8 comments · Fixed by #41799
Closed
1 of 2 tasks

Add a compatibility with Opensearch search for log management #33619

djadeau opened this issue Aug 22, 2023 · 8 comments · Fixed by #41799
Assignees
Labels

Comments

@djadeau
Copy link

djadeau commented Aug 22, 2023

Description

Dear Airflow team,

Today, it is possible to configure Airflow to read logs of the tasks from ElasticSearch.

Is it possible to add the support of Opensearch as source of the task logs ?

Thank you.

Use case/motivation

Log sinks are often used in large companies. Concentrate logs in a log sinks is very practical for searches.

Opensearch and Elasticsearch have similar methods, so it should not create major change.

ElasticSearch has added some checks in the client library, so it is not possible anymore to Opensearch with the elasticsearch library.

Cloud providers such as OVHCloud or Scaleway, propose Opensearch as log manager as a service.

Opensearch is a full opensource solution contrary to Elasticsearch.

Related issues

No

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@djadeau djadeau added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Aug 22, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 22, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@eladkal
Copy link
Contributor

eladkal commented Aug 22, 2023

@cjames23 is working on opensearch hook

@eladkal eladkal added provider:amazon-aws AWS/Amazon - related issues area:providers good first issue and removed needs-triage label for new issues that we didn't triage yet labels Aug 22, 2023
@cjames23
Copy link
Contributor

Sorry about the delay on this. If no one has made any of the Open Search capabilities I am almost complete with the hook and some cursory operators for creating indexes, documents and searching an index. I need to finish writing unit and system tests and documentation.

@cjames23
Copy link
Contributor

cjames23 commented Oct 3, 2023

@eladkal do you want to assign this to me with the two open PRs I have.

@cjames23
Copy link
Contributor

OpenSearch provider was merged but does not have log integration yet for airflow task log integrations. Currently working on adding support for the AWS Managed version of OpenSearch and then I will begin working on the log integrations.

@erikvatt
Copy link

erikvatt commented Mar 8, 2024

@cjames23 Have you started working on OpenSearch log integration?

@eladkal
Copy link
Contributor

eladkal commented Mar 8, 2024

I think that #34693 has most of the needed logic for AWS integration it just require adjustments after the OpenSearch provider was implemented. Once this is completed we can start work on log integration.
Not sure though if @cjames23 is working on it

@ftforce
Copy link

ftforce commented Mar 20, 2024

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants