-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Search Provider #34705
Add Open Search Provider #34705
Conversation
…opensearchqueryoperator unit test
…opensearch to extra-packages-ref.rst
System tests are not triggered as part of the CI. They are just used as example and also as system test/integration test if anybody wants to execute it (and as such, needs to setup the infra). The approach taken by the community is your write system tests in the Airflow repository but you execute them on your own with your infra set up. As an example, in the Amazon provider package, all system tests rely on AWS services (thus AWS account). These system tests are not triggered as part of Airflow CI but AWS team trigger frequently and results are accessible through a dashboard. |
@eladkal any advice on the failure that is happening with the CI image build step and the static checks? I ran breeze static checks against all files locally and do not receive the same failure. |
Those changes were because pre-commit checks failed locally for those things after a merge pull. |
What an odd static check to fail, I can't see how it could be related. When the workflow ends I'll bump it and see if it was just flake. It may also be broken in main, it happens some times. |
If the checks fail after this merge from main do you want me to include any fixes here for the breeze mypy issue? I think it just needs to be changed from ignore[misc] to ignore[attr-defined]. Not sure about the unit tests that are failing though from core. |
We have identified the issue |
Fixed #34941 and few other issues that caused broken main. Rebasing/resolving conflicts (generally regenerating breeze images with. |
🎉 🎉 🎉 🎉 🎉 🎉 |
Nice, congrats! |
Hi @cjames23, |
Add Open Search Provider --------- Co-authored-by: Hussein Awala <hussein@awala.fr> Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com> (cherry picked from commit 94f1441)
This provider would be a pre-requisite for adding functionality to the Amazon provider for the AWS managed service for OpenSearch. This was discussed in a different PR which will be blocked by this PR now. both PRs would be pre-work for completing #33619 and adding Open Search log integration.
Open questions to more experienced contributors:
Email sent for Lazy Consensus to the dev-list.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.