Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base aws classes in amazon provider Operators/Sensors/Triggers #35278

Open
18 of 28 tasks
Taragolis opened this issue Oct 30, 2023 · 7 comments
Open
18 of 28 tasks

Use base aws classes in amazon provider Operators/Sensors/Triggers #35278

Taragolis opened this issue Oct 30, 2023 · 7 comments
Labels
area:providers kind:meta High-level information important to the community provider:amazon-aws AWS/Amazon - related issues

Comments

@Taragolis
Copy link
Contributor

Taragolis commented Oct 30, 2023

Body

Right now some inconsistency exists between different Operators/Sensors/Triggers which are use AwsBaseGeneric hook.
After #34784 and #34884 we could make all of them (except Transfer Operators) use same subset of generic attributes.

It might make more easier to end users use this objects (don't need to think is it region or region_name or is it even support this arguments), as well as make easier extend by new new hook parameters to all this operators in the one go.

General Approach for solve each case:

  • Use AwsBaseOperator for operators, AwsBaseSensor for sensors. In some very specific case e.g. multi inheritance required to use AwsBaseHookMixin (see: AppflowRecordsShortCircuitOperator)
  • Provide additional arguments to AwsBaseWaiterTrigger (if required)
  • Wrap template_fields parameters
  • Attach generic documentation into the service specific page into the Amazon Provider Documentation
  • Validate that all parameters propagated to operator/sensor specific hook

All this steps already done for some of the operators, so it could be use as a reference

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@Taragolis Taragolis added provider:amazon-aws AWS/Amazon - related issues area:providers kind:meta High-level information important to the community labels Oct 30, 2023
@ferruzzi
Copy link
Contributor

Thanks for getting this set up!

@gopidesupavan
Copy link
Contributor

gopidesupavan commented May 30, 2024

@Taragolis i am happy to look into this Use base aws classes in AWS Glue Crawlers Operators/Sensors/Triggers ? or anyone is working already?

@prakharcode
Copy link
Contributor

@Taragolis I am happy to take EMR, EC2 and S3 (operators) here

@gopidesupavan
Copy link
Contributor

@vincbeck @eladkal Working on this Use base aws classes in AWS Glue Data Catalog Sensors didnt find anything in the documentation and example code for this. Planning to add them here https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/operators/glue.html is this fine?

@vincbeck
Copy link
Contributor

@vincbeck @eladkal Working on this Use base aws classes in AWS Glue Data Catalog Sensors didnt find anything in the documentation and example code for this. Planning to add them here https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/operators/glue.html is this fine?

Please yes :)

@eladkal
Copy link
Contributor

eladkal commented Aug 25, 2024

@gopidesupavan do you plan to address the other Glue services that were left?

@gopidesupavan
Copy link
Contributor

@eladkal Yes will update other services, coming week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:meta High-level information important to the community provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

No branches or pull requests

6 participants