Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing unit tests for some modules in providers package #8278

Closed
23 tasks done
mik-laj opened this issue Apr 13, 2020 · 19 comments · Fixed by #10799
Closed
23 tasks done

Missing unit tests for some modules in providers package #8278

mik-laj opened this issue Apr 13, 2020 · 19 comments · Fixed by #10799
Labels
good first issue kind:bug This is a clearly a bug

Comments

@mik-laj
Copy link
Member

mik-laj commented Apr 13, 2020 •
edited
Loading

Description

We have a rule that every file in the providers directory should have tests. This is true in many cases, but there are minor exceptions.
https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L29-L50

  • tests/providers/amazon/aws/hooks/test_athena.py
  • tests/providers/apache/cassandra/sensors/test_record.py
  • tests/providers/apache/cassandra/sensors/test_table.py
  • tests/providers/apache/hdfs/sensors/test_web_hdfs.py
  • tests/providers/apache/hive/operators/test_vertica_to_hive.py
  • tests/providers/apache/pig/operators/test_pig.py
  • tests/providers/apache/spark/hooks/test_spark_jdbc_script.py
  • tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
  • tests/providers/google/cloud/operators/test_datastore.py
  • tests/providers/google/cloud/operators/test_sql_to_gcs.py
  • tests/providers/google/cloud/sensors/test_bigquery.py
  • tests/providers/google/cloud/utils/test_field_sanitizer.py
  • tests/providers/google/cloud/utils/test_field_validator.py
  • tests/providers/google/cloud/utils/test_mlengine_operator_utils.py
  • tests/providers/google/cloud/utils/test_mlengine_prediction_summary.py
  • tests/providers/jenkins/hooks/test_jenkins.py
  • tests/providers/microsoft/azure/sensors/test_azure_cosmos.py
  • tests/providers/microsoft/mssql/hooks/test_mssql.py
  • tests/providers/oracle/operators/test_oracle.py
  • tests/providers/qubole/hooks/test_qubole.py
  • tests/providers/samba/hooks/test_samba.py
  • tests/providers/sqlite/operators/test_sqlite.py
  • tests/providers/yandex/hooks/test_yandex.py

I would be happy if someone would complete the missing tests.

If you decide to finish this ticket you don't have to do all the work yourself. One PR can only deal with a single file and it's ok.

Are you wondering how to start contributing to this project? Start by reading our contributor guide

Use case / motivation

Raising test coverage facilitates refactoring and prevents regression.

For the contributor, this is an opportunity to learn more about the structure of the project and to learn better good practices in writing tests in Python.

Related Issues

N/A
@mik-laj mik-laj added kind:feature Feature Requests good first issue kind:bug This is a clearly a bug and removed kind:feature Feature Requests labels Apr 13, 2020
@mik-laj mik-laj changed the title Missing tests for some modules in providers package Missing unit tests for some modules in providers package Apr 13, 2020
@rcjsuen rcjsuen mentioned this issue Apr 14, 2020
Merged
5 tasks
@joppevos joppevos mentioned this issue May 23, 2020
Merged
6 tasks
@samuelkhtu
Copy link
Contributor

If no one is working on the test_mssql.py, I can take work it.

tests/providers/microsoft/mssql/hooks/test_mssql.py

This was referenced Jun 17, 2020
Closed
Closed
Closed
@chipmyersjr chipmyersjr mentioned this issue Jun 21, 2020
Merged
6 tasks
@mik-laj mik-laj mentioned this issue Jun 22, 2020
Merged
6 tasks
@ipeluffo ipeluffo mentioned this issue Jun 23, 2020
Merged
6 tasks
@chipmyersjr chipmyersjr mentioned this issue Jun 29, 2020
Merged
6 tasks
subkanthi pushed a commit to subkanthi/airflow that referenced this issue Jul 5, 2020
[AIRFLOW-8278] Added tests for yandex hooks apache#8278
510b7b8
@subkanthi
Copy link
Contributor

Added tests for Yandex hook

  • tests/providers/yandex/hooks/test_yandex.py

https://github.com/apache/airflow/pull/9665/files

subkanthi pushed a commit to subkanthi/airflow that referenced this issue Jul 5, 2020
[AIRFLOW-8278] Fixed lint errors for yandex hooks tests apache#8278
f6211ec
subkanthi pushed a commit to subkanthi/airflow that referenced this issue Jul 5, 2020
[AIRFLOW-8278] Fixed lint errors for yandex hooks tests apache#8278
294f958
subkanthi pushed a commit to subkanthi/airflow that referenced this issue Jul 5, 2020
[AIRFLOW-8278] Fixed flake8 errors apache#8278
4904a46
@mik-laj mik-laj mentioned this issue Jul 5, 2020
Merged
@chipmyersjr chipmyersjr mentioned this issue Jul 7, 2020
Merged
6 tasks
@subkanthi
Copy link
Contributor

Added unit test for jenkins hook
#9767

@rootcss
Copy link
Contributor

rootcss commented Jul 18, 2020 •
edited
Loading

I've picked Cassandra table and record sensors hook. (primarily because, I ❤️ Cassandra)

 tests/providers/apache/cassandra/sensors/test_record.py
 tests/providers/apache/cassandra/sensors/test_table.py

@rootcss rootcss mentioned this issue Jul 18, 2020
Merged
6 tasks
@rootcss
Copy link
Contributor

rootcss commented Jul 18, 2020

Picked tests/providers/apache/hdfs/sensors/test_web_hdfs.py

@mik-laj
Copy link
Member Author

mik-laj commented Jul 18, 2020

@rootcss Wouldn't you be willing to give some love for this ticket?
#8189

@rootcss
Copy link
Contributor

rootcss commented Jul 18, 2020

@rootcss Wouldn't you be willing to give some love for this ticket?
#8189

@mik-laj Here's some more ❤️ for Cassandra - #9877

@ari-hacks
Copy link

I'd like to tackle tests/providers/microsoft/azure/sensors/test_azure_cosmos.py

@chipmyersjr chipmyersjr mentioned this issue Jul 22, 2020
Merged
@rootcss
Copy link
Contributor

rootcss commented Jul 22, 2020 •
edited
Loading

I'm picking the following tests:

  • tests/providers/google/cloud/utils/test_field_sanitizer.py
  • tests/providers/google/cloud/utils/test_field_validator.py
  • tests/providers/microsoft/mssql/hooks/test_mssql.py
  • tests/providers/samba/hooks/test_samba.py
    cc: @mik-laj

@rootcss rootcss mentioned this issue Jul 23, 2020
Merged
@rootcss
Copy link
Contributor

rootcss commented Jul 23, 2020

@mik-laj MsSqlHook in airflow/providers/microsoft/mssql/hooks/mssql.py is deprecated. Do we still need to add tests for it?

This was referenced Jul 25, 2020
Merged
Merged
@mik-laj
Copy link
Member Author

mik-laj commented Jul 25, 2020

@rootcss If someone is willing, they can add tests, but it is not necessary. I will be happy without tests for this module.

@mik-laj
Copy link
Member Author

mik-laj commented Jul 25, 2020

@rootcss As far as I know, Tomek is working on tests for Datastore.

@turbaszek Can you confirm that?

@mik-laj
Copy link
Member Author

mik-laj commented Jul 25, 2020

I found PR: PolideaInternal#946

@rootcss
Copy link
Contributor

rootcss commented Jul 26, 2020

@rootcss As far as I know, Tomek is working on tests for Datastore.

@turbaszek Can you confirm that?

Sure. I've removed it from my list.

@rootcss rootcss mentioned this issue Jul 26, 2020
Merged
@rootcss
Copy link
Contributor

rootcss commented Jul 26, 2020

@mik-laj I think, rest of the tests have been picked already. We're close to close this issue :)

@rootcss
Copy link
Contributor

rootcss commented Jul 27, 2020

I've picked tests/providers/google/cloud/utils/test_mlengine_prediction_summary.py

@rootcss rootcss mentioned this issue Jul 27, 2020
Merged
@mik-laj mik-laj mentioned this issue Sep 8, 2020
Merged
@mik-laj
Copy link
Member Author

mik-laj commented Sep 8, 2020

The ticket has been completed :-D

Thanks to everyone who participated in this task.
More info: #10799

@potiuk
Copy link
Member

potiuk commented Sep 8, 2020

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

@rootcss
Copy link
Contributor

rootcss commented Sep 8, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

All files in providers package have unit tests PolideaInternal/airflow
6 participants
@potiuk @rootcss @mik-laj @subkanthi @ari-hacks @samuelkhtu