Mark task as failed when it fails "sending" in Celery #10881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
ashb
force-pushed
the
hard-celery-error-fails-task
branch
from
7f8dcfd
to
4300c2b
Compare
kaxil
approved these changes
Sep 11, 2020
|
One test is failing |
|
@olchas this sounds like it may solve the issue you observed when cluster was scaling up |
turbaszek
reviewed
Sep 11, 2020
turbaszek
approved these changes
Sep 11, 2020
ashb
force-pushed
the
hard-celery-error-fails-task
branch
from
4300c2b
to
fc119a0
Compare
If a task failed hard on celery, _before_ being able to execute the airflow code the task would end up stuck in queued state. This change makes it get retried. This was discovered in load testing the HA work (but unrelated to HA changes), where I swamped the kube-dns pod, meaning the worker was sometimes unable to resolve the db name via DNS, so the state in the DB was never updated
ashb
force-pushed
the
hard-celery-error-fails-task
branch
from
fc119a0
to
77cb73d
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a task failed hard on celery, before being able to execute the
airflow code the task would end up stuck in queued state. This change
makes it get retried.
This was discovered in load testing the HA work (but unrelated to HA
changes), where I swamped the kube-dns pod, meaning the worker was
sometimes unable to resolve the db name via DNS, so the state in the DB
was never updated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.