Add GCP Service Account rule #11230
Merged
Add GCP Service Account rule #11230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
added
the
area:upgrade
turbaszek
reviewed
Oct 3, 2020
turbaszek
reviewed
Oct 3, 2020
turbaszek
reviewed
Oct 3, 2020
turbaszek
reviewed
Oct 3, 2020
turbaszek
approved these changes
Oct 3, 2020
There was a problem hiding this comment.
LGTM!
GCP service account key deprecation
-----------------------------------
Option has been removed because it is no longer supported by the Google Kubernetes Engine.
Problems:
1. This option has been removed because it is no longer supported by the Google Kubernetes Engine. The new recommended service account keys for the Google Cloud management method is Workload Identity.
|
Thanks for the feedback as always @turbaszek 🚀 |
|
@pcandoalmeida Can you please rebase to latest v1-10-test ? It should work now. |
|
@pcandoalmeida can you clean up your PR, there's a lot of unrelated commits |
|
Hey @turbaszek sure, will do! |
pcandoalmeida
force-pushed
the
v1-10-test
branch
from
e63932f
to
c27faa8
Compare
|
cool :) |
kaxil
pushed a commit
that referenced
this pull request
Oct 11, 2020
turbaszek
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 21, 2020
turbaszek
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 23, 2020
(cherry picked from commit 5a6c133)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry picked from commit 5a6c133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GCP Service Account rule check for Kubernetes configuration.
Related: #8765
Closes: #11047