Workarounds docker-compose-v2 environment passing #17052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker-compose v2 parsing of env file bug detected in apache#16949 and eventual disabling of docker-compose-v2 in apache#16989 found another workaround after discussing with docker-compose maintainers in docker-archive/compose-cli#1917 The VAR=${VAR} pattern seems to work for all cases for Airflow because we never rely on the fact if variable is set or not - we always take into account value of the variable (that is by design and strictly followed everywhere). Therefore we are sure this workaround is going to work for us. However we should remove that workaround once the bug is fixed in Docker-Compose V2.
|
@oyarushe - so it turned out to be more complex but we seem to have a temporary workaround that seems to works for both docker and docker-compose (see docker-archive/compose-cli#1917) |
yeah, I monitored all things regarding it. Nice work @potiuk! |
|
ACH And found a problem there with PACKAGE_FORMAT variable :) |
|
closing as this does not really work for docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker-compose v2 parsing of env file bug detected
in #16949 and eventual disabling of docker-compose-v2 in #16989
found another workaround after discussing with docker-compose
maintainers in docker-archive/compose-cli#1917
The VAR=${VAR} pattern seems to work for all cases for Airflow
because we never rely on the fact if variable is set or not -
we always take into account value of the variable (that is by
design and strictly followed everywhere). Therefore we are
sure this workaround is going to work for us.
However we should remove that workaround once the bug is fixed in
Docker-Compose V2.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.