Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Cloud Tasks how-to documentation #20145

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

kazanzhy
Copy link
Contributor

@kazanzhy kazanzhy commented Dec 8, 2021

closes: #8208
related: #8209

Add how-to documentation for Google Cloud Tasks.
I've built successfully in a local machine and made static checks.

This PR with the #20138 also closes: #8209

@dstandish
Copy link
Contributor

looks like black failed

@kazanzhy kazanzhy force-pushed the fix_issue_8208_cloud_tasks_docs branch from 87905e0 to 0d726af Compare December 8, 2021 19:32
@kazanzhy
Copy link
Contributor Author

kazanzhy commented Dec 8, 2021

That's strange.
I've successfully built docs locally and I can't figure out why images build is failing

@potiuk
Copy link
Member

potiuk commented Dec 8, 2021

That's strange. I've successfully built docs locally and I can't figure out why images build is failing

This is not images - you just should run -pre-commit and format the code with black via pre-commit.

@kazanzhy kazanzhy force-pushed the fix_issue_8208_cloud_tasks_docs branch 2 times, most recently from e1cc840 to 32f36e0 Compare December 9, 2021 12:07
@kazanzhy
Copy link
Contributor Author

kazanzhy commented Dec 9, 2021

Now seems to be ok @dstandish
The issue was in mypy. Some methods' parameters had no types like response_view: Optional = None.
I passed response_view: Optional[Task.View] = None in according to the documentation.

@kazanzhy kazanzhy force-pushed the fix_issue_8208_cloud_tasks_docs branch from 32f36e0 to 3bf061e Compare December 10, 2021 22:09
@potiuk potiuk merged commit 22341b9 into apache:main Dec 11, 2021
@kazanzhy kazanzhy deleted the fix_issue_8208_cloud_tasks_docs branch December 11, 2021 20:37
@potiuk potiuk added the mypy Fixing MyPy problems after bumpin MyPy to 0.990 label Dec 13, 2021
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation mypy Fixing MyPy problems after bumpin MyPy to 0.990 provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing guides for GCP operators Create guide for Cloud Tasks operators
4 participants