Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index for event column in log table #23625

Merged
merged 1 commit into from
May 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

"""Add index for ``event`` column in ``log`` table.

Revision ID: 1de7bc13c950
Revises: b1b348e02d07
Create Date: 2022-05-10 18:18:43.484829

"""

from alembic import op

# revision identifiers, used by Alembic.
revision = '1de7bc13c950'
down_revision = 'b1b348e02d07'
branch_labels = None
depends_on = None
airflow_version = '2.3.1'


def upgrade():
"""Apply Add index for ``event`` column in ``log`` table."""
op.create_index('idx_log_event', 'log', ['event'], unique=False)


def downgrade():
"""Unapply Add index for ``event`` column in ``log`` table."""
op.drop_index('idx_log_event', table_name='log')
5 changes: 4 additions & 1 deletion airflow/models/log.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ class Log(Base):
owner = Column(String(500))
extra = Column(Text)

__table_args__ = (Index('idx_log_dag', dag_id),)
__table_args__ = (
Index('idx_log_dag', dag_id),
Index('idx_log_event', event),
)

def __init__(self, event, task_instance=None, owner=None, extra=None, **kwargs):
self.dttm = timezone.utcnow()
Expand Down
4 changes: 3 additions & 1 deletion docs/apache-airflow/migrations-ref.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ Here's the list of all the Database Migrations that are executed via when you ru
.. Beginning of auto-generated table

+---------------------------------+-------------------+-------------+--------------------------------------------------------------+
| ``b1b348e02d07`` (head) | ``75d5ed6c2b43`` | ``2.3.0`` | Update dag.default_view to grid |
| ``1de7bc13c950`` (head) | ``b1b348e02d07`` | ``2.3.1`` | Add index for ``event`` column in ``log`` table. |
+---------------------------------+-------------------+-------------+--------------------------------------------------------------+
| ``b1b348e02d07`` | ``75d5ed6c2b43`` | ``2.3.0`` | Update dag.default_view to grid |
+---------------------------------+-------------------+-------------+--------------------------------------------------------------+
| ``75d5ed6c2b43`` | ``909884dea523`` | ``2.3.0`` | Add map_index to Log. |
+---------------------------------+-------------------+-------------+--------------------------------------------------------------+
Expand Down