Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run_unit_tests.sh #24

Closed
wants to merge 2 commits into from
Closed

Fix run_unit_tests.sh #24

wants to merge 2 commits into from

Conversation

afarbos
Copy link

@afarbos afarbos commented Jun 12, 2015

I don't know if it's a mistake, but the airflow/www/static/coverage does not exist. So, if anyone want to try run_unit_tests.sh, he will have an error from rm and he will not able to use it.

Moreover, in https://github.com/airbnb/airflow/blob/master/CONTRIBUTING.md#testing you don't specify to install nose so you can add it to your requierements.txt or specify it in your CONTRIBUTING.md

To finish, are you interested by the output of the test ?

@afarbos afarbos changed the title Remove line trying to delete file in a non existing folder Fix run_unit_tests.sh Jun 12, 2015
@mistercrunch
Copy link
Member

Yes indeed we are interested in the html results of the test. Notice that there's a symlink pointing to that folder from the web server's static folder here:
https://github.com/airbnb/airflow/blob/master/airflow/www/static/docs

You're right, nose should be in the requirements.txt and the setup.py devel extras_require

The idea with the rm statement is to make room for the new export, the bash script should create the folder if it doesn't exist, then empty it to make place for the output of nose

@artwr
Copy link
Contributor

artwr commented Jun 13, 2015

@globus. I had an old open PR to do this :

if [[ -d "airflow/www/static/coverage" ]]
then
  rm airflow/www/static/coverage/*
else
  mkdir -p "airflow/www/static/coverage"
fi

Feel free to reuse

@afarbos
Copy link
Author

afarbos commented Jun 15, 2015

Your else is not usefull because you use -p for mkdir and just adding -f to remove should the error message and so you can remove the if.

@mistercrunch
Copy link
Member

a6f42ab and 49201ee are equivalent to this, closing. Thanks for pointing these out!

gsemet pushed a commit to gsemet/incubator-airflow that referenced this pull request Nov 6, 2017
* Small cleanup to address PR comments

* Remove use of enum

* Change back to 3.4
Fokko pushed a commit to Fokko/incubator-airflow that referenced this pull request Apr 19, 2018
* Small cleanup to address PR comments

* Remove use of enum

* Change back to 3.4
Fokko pushed a commit to Fokko/incubator-airflow that referenced this pull request Apr 22, 2018
* Small cleanup to address PR comments

* Remove use of enum

* Change back to 3.4
asfgit pushed a commit that referenced this pull request Apr 22, 2018
* Small cleanup to address PR comments

* Remove use of enum

* Change back to 3.4
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
* Small cleanup to address PR comments

* Remove use of enum

* Change back to 3.4
boralyl pushed a commit to upsight/airflow that referenced this pull request Apr 1, 2019
…A-3267 to develop

* commit '57aeeafd0cdc675bdd00324ccd52c7e09974f725':
  DATA-3276: bump version and actually include patch file
  DATA-3267: display dagrun.conf in UI
rajatsri28 pushed a commit to rajatsri28/airflow that referenced this pull request Nov 29, 2019
* [AIRFLOW-2731] Raise psutil restriction to <6.0.0

* [TWTR][AIRFLOW-5925] Relax funcsigs requirement, open source PR hasnt landed yet
aoen added a commit to aoen/incubator-airflow that referenced this pull request Dec 9, 2019
* [AIRFLOW-2731] Raise psutil restriction to <6.0.0

* [TWTR][AIRFLOW-5925] Relax funcsigs requirement, open source PR hasnt landed yet
aoen pushed a commit to aoen/incubator-airflow that referenced this pull request Apr 10, 2020
* 99ee040: CP from 1.10+twtr

* 2e01c24: CP from 1.10.4 ([TWTR][AIRFLOW-4939] Fixup use of fallback kwarg in conf.getint)

* 00cb4ae: [TWTR][AIRFLOW-XXXX] Cherry-pick d4a83bc and bump version (apache#21)

* CP 51b1aee: Relax version requiremets (apache#24)

* CP 67a4d1c: [CX-16266] Change with reference to 1a4c164 commit in open source (apache#25)

* CP 54bd095: [TWTR][CX-17516] Queue tasks already being handled by the executor (apache#26)

* CP 87fcc1c: [TWTR][CX-17516] Requeue tasks in the queued state (apache#27)

* CP 98a1ca9: [AIRFLOW-6625] Explicitly log using utf-8 encoding (apache#7247) (apache#31)

* fixing models.py and jobs.py file fix after CP

* fixing typo and version bump

Co-authored-by: Vishesh Jain <visheshj@twitter.com>
mobuchowski pushed a commit to mobuchowski/airflow that referenced this pull request Jan 4, 2022
apache#24)

* Add a documentation about contributing, including how to run integration tests

* Fix ordering (no effect on rendering)

* Adding code of conduct and removing java references
mobuchowski pushed a commit to mobuchowski/airflow that referenced this pull request Jan 4, 2022
Signed-off-by: Julien Le Dem <julien@apache.org>
rajatsri28 pushed a commit to rajatsri28/airflow that referenced this pull request Jan 25, 2022
* EWT-569 : Initial Commit for migrations

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  76fe7ac from 1.10.4

* CP Contains fb64f2e: [TWTR][AIRFLOW-XXX] Twitter Airflow Customizations + Fixup job scheduling without explicit_defaults_for_timestamp

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick 91d2b00
[CP][EWT-548][AIRFLOW-6527] Make send_task_to_executor timeout configurable (apache#63)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick 91d2b00
CP contains [EWT-16]: Airflow fix for manual trigger during version upgrade (apache#13)

* [EWT-16]: Airflow fix for manual trigger during version upgrade

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick 91d2b00
[CP][EWT-548][AIRFLOW-6527] Make send_task_to_executor timeout configurable (apache#63)

CP of f757a54

* CP(55bb579) [AIRFLOW-5597] Linkify urls in task instance log (apache#16)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 94cdcf6
[CP] Contains [AIRFLOW-5597] Linkify urls in task instance log

CP of f757a54

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  4ce8d4c from 1.10.4
CP contains [TWTTR] Fix for rendering code on UI (apache#34)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  299b4d8 from 1.10.4
CP contains [TWTR] CP from 1.10+twtr (apache#35)

* 99ee040: CP from 1.10+twtr

* 2e01c24: CP from 1.10.4 ([TWTR][AIRFLOW-4939] Fixup use of fallback kwarg in conf.getint)

* 00cb4ae: [TWTR][AIRFLOW-XXXX] Cherry-pick d4a83bc and bump version (apache#21)

* CP 51b1aee: Relax version requiremets (apache#24)

* CP 67a4d1c: [CX-16266] Change with reference to 1a4c164 commit in open source (apache#25)

* CP 54bd095: [TWTR][CX-17516] Queue tasks already being handled by the executor (apache#26)

* CP 87fcc1c: [TWTR][CX-17516] Requeue tasks in the queued state (apache#27)

* CP 98a1ca9: [AIRFLOW-6625] Explicitly log using utf-8 encoding (apache#7247) (apache#31)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : f7050fb
CP Contains Experiment API path fix (apache#37)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  8a689af from 1.10.4
CP Contains Export scheduler env variable into worker pods. (apache#38)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  5875a15 from 1.10.4
Cp Contains [EWT-115][EWT-118] Initialise dag var to None and fix for DagModel.fileloc (missed in EWT-16) (apache#39)

* [EWT-569] Airflow Upgrade to 1.10.14, Cherry-Pick  a68e2b3 from 1.10.4
[CX-16591] Fix regex to work with impersonated clusters like airflow_scheduler_ddavydov (apache#42)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : e9642c2
[CP][EWT-128] Fetch task logs from worker pods (19ac45a) (apache#43)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : d5d0a07
[CP][AIRFLOW-6561][EWT-290]: Adding priority class and default resource for worker pod. (apache#47)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 9b58c88
[CP][EWT-302]Patch Pool.DEFAULT_POOL_NAME in BaseOperator (apache#8587) (apache#49)

Open source commit id: b37ce29

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 7b52a71
[CP][AIRFLOW-3121] Define closed property on StreamLogWriter (apache#3955) (apache#52)

CP of 2d5b8a5

* [EWT-361] Fix broken regex pattern for extracting dataflow job id (apache#51)

Update the dataflow URL regex as per AIRFLOW-9323

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 4b5b977
EWT-370: Use python3 to launch the dataflow job. (apache#53)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 596e24f
* [EWT-450] fixing sla miss triggering duplicate alerts every minute (apache#56)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : b3d7fb4
[CP] Handle IntegrityErrors for trigger dagruns & add Stacktrace when DagFileProcessorManager gets killed (apache#57)

CP of faaf179 - from master
CP of 2102122 - from 1.10.12

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : bac4acd
[TWTR][EWT-472] Add lifecycle support while launching worker pods (apache#59)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 6162402
[TWTTR] Don't enqueue tasks again if already queued for K8sExecutor(apache#60)

Basically reverting commit 87fcc1c  and making changes specifically into the Celery Executor class only.

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 1991419
[CP][TWTR][EWT-377] Fix DagBag bug when a Dag has invalid schedule_interval (apache#61)

CP of 5605d10 & apache#11462

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : 48be0f9
[TWTR][EWT-350] Reverting the last commit partially (apache#62)

* [EWT-569] Airflow Upgrade to 1.10.14 [CP] from 1.10.4+twtr : d8c473e
[CP][EWT-548][AIRFLOW-6527] Make send_task_to_executor timeout configurable (apache#63)

CP of f757a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants