Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify BigQueryCreateExternalTableOperator to use updated hook function #24363

Merged
merged 3 commits into from
Jul 12, 2022

Conversation

cswpy
Copy link
Contributor

@cswpy cswpy commented Jun 10, 2022

Fixes: #24160

Modified the unit tests to verify that create_empty_table is called at least once.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@cswpy cswpy requested a review from turbaszek as a code owner June 10, 2022 07:17
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 10, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 10, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@cswpy
Copy link
Contributor Author

cswpy commented Jun 19, 2022

@malthe @eladkal @alexInhert I see that issue #24416 is already merged, can we proceed with this PR? Thanks.

@eladkal
Copy link
Contributor

eladkal commented Jun 19, 2022

@malthe @eladkal @alexInhert I see that issue #24416 is already merged, can we proceed with this PR? Thanks.

Im away from laptop so cant check but if I rember correctly #24416 changed the name of the function that you import so you need to rebase and apply the needed changes here.

@cswpy
Copy link
Contributor Author

cswpy commented Jun 19, 2022

I feel like I did something wrong here... not exactly familiar with the workflow to rebase. I first rebased my commit to the latest apache remote branch and then pulled changes from my remote branch, lastly made mods to the PR. Not sure why my code does not pass the up-to-date checker, can anyone advise what to do next? Many thanks.

@potiuk
Copy link
Member

potiuk commented Jun 19, 2022

Rebasing is easiest with drop-down next to "Update branch". button. See the instructions on rebase in our CONTRIBUTING docs https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id14 they have all details @cswpy . The worst case - take your changes and re-apply them manually on top of main if you are somehow lost with your branch. you can start a new PR and close this one - no problem with that.

@cswpy
Copy link
Contributor Author

cswpy commented Jun 20, 2022

@potiuk I think it's ready to merge now :) Thanks for the tips.

@potiuk
Copy link
Member

potiuk commented Jun 20, 2022

The test is failing I am afraid

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 20, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Jun 21, 2022

Still docs and tests failing. Please fix and rebase it :)

@cswpy
Copy link
Contributor Author

cswpy commented Jun 29, 2022

@eladkal @potiuk I believe the PR is ready to be merged😀

@cswpy
Copy link
Contributor Author

cswpy commented Jul 7, 2022

Now the PR is failing some checks... I believe this is due to the new commits that has already merged into main, where I rebased my commit onto. Can you advise me on how to proceed? Thanks

@potiuk
Copy link
Member

potiuk commented Jul 7, 2022

Just continue rebasing. It's unlikely broken tests will stay broken for a long time they are usually fixed quickly. You were just unlucky when you hit them.

@cswpy cswpy force-pushed the main branch 2 times, most recently from 22558eb to 94f54fe Compare July 9, 2022 04:49
@cswpy
Copy link
Contributor Author

cswpy commented Jul 9, 2022

Hi @potiuk , all checks passed 😃

@cswpy cswpy force-pushed the main branch 4 times, most recently from ea0c13f to a032170 Compare July 12, 2022 00:07
@eladkal eladkal changed the title Fixed BigQueryCreateExternalTableOperator and its unit test (#24160) Modify BigQueryCreateExternalTableOperator to use updated hook function Jul 12, 2022
@eladkal eladkal merged commit c618da4 into apache:main Jul 12, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 12, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQueryCreateExternalTableOperator uses deprecated function
6 participants