Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid task logs filtering and local time #24403

Merged

Conversation

pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Jun 12, 2022

Follow up of #24249.

Enforcing log parsing to add:

  • Local datetime for the logs
  • Filter on the log level (DEBUG, INFO, WARNING, etc.)
  • Filter on the log group (python logger that emitted the log).

The parsing function is quite light at the moment, I still decided to memoized the results as I assume this could become quite expensive if the user requests the log full_content.

I also moved moment initialization for tests from testUtils to jest-setup.js. (Sometimes tests don't need a wrapper, and we still have to import testUtils module to get moment defined)

Tested with mapped tasks and task group. ✔️

image
image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 12, 2022
@pierrejeambrun pierrejeambrun force-pushed the grid-task-logs-filtering-and-local-time branch 4 times, most recently from 8e9b510 to 2a1b43a Compare June 12, 2022 20:47
@pierrejeambrun pierrejeambrun force-pushed the grid-task-logs-filtering-and-local-time branch from ee02318 to c409056 Compare June 13, 2022 17:22
@bbovenzi
Copy link
Contributor

Let's at least set a minWidth to the file dropdown to the default text doesn't get cut off.
Let's set a fixed with to the log level dropdown, so it too doesn't move around.

Screen Shot 2022-06-13 at 4 27 39 PM

Screen Shot 2022-06-13 at 4 27 47 PM

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I think people will be really excited for all of this!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 13, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@pierrejeambrun pierrejeambrun force-pushed the grid-task-logs-filtering-and-local-time branch from e9f3a2e to 2c4e83d Compare June 13, 2022 22:32
@pierrejeambrun pierrejeambrun force-pushed the grid-task-logs-filtering-and-local-time branch from 2c4e83d to 4f04586 Compare June 13, 2022 23:15
@bbovenzi bbovenzi merged commit fe2ef0f into apache:main Jun 14, 2022
@pierrejeambrun pierrejeambrun deleted the grid-task-logs-filtering-and-local-time branch June 14, 2022 17:24
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants