Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actual_file_to_check with rendered path #24451

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Conversation

remem9527
Copy link
Contributor

The new added attribute self.actual_file_to_check is not one of template_fields and is initiated in self.__init__(). So, it need to be updated after self.path is rendered. Otherwise, the template in self.path will not work.

@alexkruc

The new added attribute `self.actual_file_to_check` is not one of template_fields and is initiated in `self.__init__()`. So, it need to be updated after `self.path` is rendered. Otherwise, the template in `self.path` will not work.
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 14, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

It is not necessary for `self.actual_file_to_check` to be an attribute. Deleted it from `__init__`. Replaced it with a local variable in `SFTPSensor.poker()`.
@remem9527 remem9527 requested a review from josh-fell June 17, 2022 13:16
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 17, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@josh-fell josh-fell merged commit ad297c9 into apache:main Jun 17, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 17, 2022

Awesome work, congrats on your first merged pull request!

@josh-fell
Copy link
Contributor

Woohoo! First commit! Congrats! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants