Make extra_args in S3Hook immutable between calls #24527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
Taragolis
force-pushed
the
aws-s3hook-extra-args
branch
from
0303b7d
to
a2ae36c
Compare
Taragolis
force-pushed
the
aws-s3hook-extra-args
branch
from
a2ae36c
to
2fc5560
Compare
potiuk
approved these changes
Jun 19, 2022
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At that moment in S3Hooks methods:
load_file,load_string,load_bytes,load_file_objmight changeextra_argsargument.And if user call this methods multiple times in single operator with different arguments the result could be unexpected.