Add on_kill() to kill Trino query if Airflow task is killed #24559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2022
Merged
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
reviewed
Jun 20, 2022
|
|
||
| def on_kill(self) -> None: | ||
| if self.hook is not None and isinstance(self.hook, TrinoHook): | ||
| query_id = "'" + self.hook.query_id + "'" |
There was a problem hiding this comment.
Does the following work?
Suggested change
| query_id = "'" + self.hook.query_id + "'" | |
| query_id = f"'{self.hook.query_id}'" |
kaxil
reviewed
Jun 20, 2022
| @@ -79,3 +81,18 @@ def execute(self, context: 'Context') -> None: | |||
| self.hook.run( | |||
| sql=self.sql, autocommit=self.autocommit, parameters=self.parameters, handler=self.handler | |||
| ) | |||
|
|
|||
| def on_kill(self) -> None: | |||
| if self.hook is not None and isinstance(self.hook, TrinoHook): | |||
There was a problem hiding this comment.
The following might be sufficient
Suggested change
| if self.hook is not None and isinstance(self.hook, TrinoHook): | |
| if isinstance(self.hook, TrinoHook): |
kaxil
approved these changes
Jun 20, 2022
eladkal
approved these changes
Jun 20, 2022
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to PR #24415.
It adds on_kill method to the TrinoOperator to kill Trino query if Airflow task is killed
cc @kaxil @eladkal
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.