Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding generic SqlToSlackOperator #24663

Merged
merged 29 commits into from
Jun 29, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
259c193
adding SqlToSlackOperator
alexkruc Jun 26, 2022
a46a309
adding SqlToSlackOperator
alexkruc Jun 26, 2022
6e7b54a
Update tests/system/providers/slack/example_sql_to_slack.py
alexkruc Jun 26, 2022
4f67dc1
Update tests/system/providers/slack/example_sql_to_slack.py
alexkruc Jun 26, 2022
cacb00d
Merge branch 'add_sql_to_slack_operator' of github.com:alexkruc/airfl…
alexkruc Jun 26, 2022
dc1acf6
Changes based on CR
alexkruc Jun 27, 2022
6589682
removing the logger initialization, using `self.log`
alexkruc Jun 27, 2022
aac9fe1
removing typo in `PrestoToSlackOperator` documentation
alexkruc Jun 27, 2022
4bb47db
removing mutual exclusive comment in `PrestoToSlackOperator` Slack pa…
alexkruc Jun 27, 2022
0cbf0d2
Fixing CI tests
alexkruc Jun 27, 2022
9b8c76d
Merge branch 'main' into add_sql_to_slack_operator
alexkruc Jun 27, 2022
21cd6ff
Merge branch 'main' into add_sql_to_slack_operator
alexkruc Jun 28, 2022
e0c2421
changed slackhook related behaviour
alexkruc Jun 28, 2022
9607fcd
fixing ci tests
alexkruc Jun 28, 2022
3247f09
removing unused imports and fixing conn_type in tests
alexkruc Jun 28, 2022
a8031d0
fix ci operator params
alexkruc Jun 28, 2022
de63ee0
removing mutually exclusive comments for slack connection
alexkruc Jun 28, 2022
387f478
backporting connection.get_hook method and removing default slack_con…
alexkruc Jun 28, 2022
7867a04
Merge branch 'main' into add_sql_to_slack_operator
alexkruc Jun 28, 2022
fe59554
adding sql_hook_params to the backport get_hook method
alexkruc Jun 28, 2022
dc4d85e
Merge branch 'add_sql_to_slack_operator' of github.com:alexkruc/airfl…
alexkruc Jun 28, 2022
d6cc88a
Update airflow/providers/slack/transfers/sql_to_slack.py
alexkruc Jun 28, 2022
748eabc
Update airflow/providers/slack/transfers/sql_to_slack.py
alexkruc Jun 28, 2022
bf522b3
testing exception thrown
alexkruc Jun 29, 2022
c8670b4
Merge branch 'add_sql_to_slack_operator' of github.com:alexkruc/airfl…
alexkruc Jun 29, 2022
3462a7f
Merge branch 'main' into add_sql_to_slack_operator
alexkruc Jun 29, 2022
f33699c
fix indentation and ci tests
alexkruc Jun 29, 2022
f3a29fb
adding skip tests for pre-commit hooks on 2.2 comp
alexkruc Jun 29, 2022
efd07a5
changed ignore compatibility check comment name
alexkruc Jun 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 25 additions & 63 deletions airflow/providers/presto/transfers/presto_to_slack.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,17 @@
# specific language governing permissions and limitations
# under the License.

import warnings
from typing import TYPE_CHECKING, Iterable, Mapping, Optional, Sequence, Union

from pandas import DataFrame
from tabulate import tabulate

from airflow.exceptions import AirflowException
from airflow.models import BaseOperator
from airflow.providers.presto.hooks.presto import PrestoHook
from airflow.providers.slack.hooks.slack_webhook import SlackWebhookHook
from airflow.providers.slack.transfers.sql_to_slack import SqlToSlackOperator

if TYPE_CHECKING:
from airflow.utils.context import Context
pass
eladkal marked this conversation as resolved.
Show resolved Hide resolved


class PrestoToSlackOperator(BaseOperator):
class PrestoToSlackOperator(SqlToSlackOperator):
"""
Executes a single SQL statement in Presto and sends the results to Slack. The results of the query are
rendered into the 'slack_message' parameter as a Pandas dataframe using a JINJA variable called '{{
Expand All @@ -47,11 +43,12 @@ class PrestoToSlackOperator(BaseOperator):
You can use the default JINJA variable {{ results_df }} to access the pandas dataframe containing the
SQL results
:param presto_conn_id: destination presto connection
:param slack_conn_id: The connection id for Slack
:param slack_conn_id: The connection id for Slack. Mutually exclusive with 'slack_token'
:param results_df_name: The name of the JINJA template's dataframe variable, default is 'results_df'
:param parameters: The parameters to pass to the SQL query
:param slack_token: The token to use to authenticate to Slack. If this is not provided, the
'webhook_token' attribute needs to be specified in the 'Extra' JSON field against the slack_conn_id
'webhook_token' attribute needs to be specified in the 'Extra' JSON field against the slack_conn_id.py
Mutually exclusive with 'slack_conn_id'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webhook_token in Extra marked as Deprecated

extra = conn.extra_dejson
web_token = extra.get('webhook_token', '')
if web_token:
warnings.warn(
"'webhook_token' in 'extra' is deprecated. Please use 'password' field",
DeprecationWarning,
stacklevel=2,
)

:param slack_channel: The channel to send message. Override default from Slack connection.
"""

Expand All @@ -66,14 +63,13 @@ def __init__(
sql: str,
slack_message: str,
presto_conn_id: str = 'presto_default',
slack_conn_id: str = 'slack_default',
slack_conn_id: Optional[str] = None,
eladkal marked this conversation as resolved.
Show resolved Hide resolved
results_df_name: str = 'results_df',
parameters: Optional[Union[Iterable, Mapping]] = None,
slack_token: Optional[str] = None,
slack_channel: Optional[str] = None,
**kwargs,
) -> None:
super().__init__(**kwargs)

self.presto_conn_id = presto_conn_id
self.sql = sql
Expand All @@ -84,58 +80,24 @@ def __init__(
self.results_df_name = results_df_name
self.slack_channel = slack_channel

def _get_query_results(self) -> DataFrame:
presto_hook = self._get_presto_hook()

self.log.info('Running SQL query: %s', self.sql)
df = presto_hook.get_pandas_df(self.sql, parameters=self.parameters)
return df

def _render_and_send_slack_message(self, context, df) -> None:
# Put the dataframe into the context and render the JINJA template fields
context[self.results_df_name] = df
self.render_template_fields(context)

slack_hook = self._get_slack_hook()
self.log.info('Sending slack message: %s', self.slack_message)
slack_hook.execute()
warnings.warn(
"""
PrestoToSlackOperator is deprecated.
Please use `airflow.providers.slack.transfers.sql_to_slack.SqlToSlackOperator`.
""",
DeprecationWarning,
stacklevel=2,
)

def _get_presto_hook(self) -> PrestoHook:
return PrestoHook(presto_conn_id=self.presto_conn_id)

def _get_slack_hook(self) -> SlackWebhookHook:
return SlackWebhookHook(
http_conn_id=self.slack_conn_id,
message=self.slack_message,
webhook_token=self.slack_token,
super().__init__(
sql=self.sql,
sql_conn_id=self.presto_conn_id,
slack_conn_id=self.slack_conn_id,
slack_webhook_token=self.slack_token,
slack_message=self.slack_message,
slack_channel=self.slack_channel,
results_df_name=self.results_df_name,
parameters=self.parameters,
**kwargs,
)

def render_template_fields(self, context, jinja_env=None) -> None:
# If this is the first render of the template fields, exclude slack_message from rendering since
# the presto results haven't been retrieved yet.
if self.times_rendered == 0:
fields_to_render: Iterable[str] = filter(lambda x: x != 'slack_message', self.template_fields)
else:
fields_to_render = self.template_fields

if not jinja_env:
jinja_env = self.get_template_env()

# Add the tabulate library into the JINJA environment
jinja_env.filters['tabulate'] = tabulate

self._do_render_template_fields(self, fields_to_render, context, jinja_env, set())
self.times_rendered += 1

def execute(self, context: 'Context') -> None:
if not self.sql.strip():
raise AirflowException("Expected 'sql' parameter is missing.")
if not self.slack_message.strip():
raise AirflowException("Expected 'slack_message' parameter is missing.")

df = self._get_query_results()

self._render_and_send_slack_message(context, df)

self.log.debug('Finished sending Presto data to Slack')
6 changes: 6 additions & 0 deletions airflow/providers/slack/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ hooks:
- airflow.providers.slack.hooks.slack
- airflow.providers.slack.hooks.slack_webhook

transfers:
- source-integration-name: SQL
target-integration-name: Slack
python-module: airflow.providers.slack.transfers.sql_to_slack
how-to-guide: /docs/apache-airflow-providers-slack/operators/sql_to_slack.rst

hook-class-names: # deprecated - to be removed after providers add dependency on Airflow 2.2.0+
- airflow.providers.slack.hooks.slack_webhook.SlackWebhookHook

Expand Down
16 changes: 16 additions & 0 deletions airflow/providers/slack/transfers/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
166 changes: 166 additions & 0 deletions airflow/providers/slack/transfers/sql_to_slack.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

from typing import TYPE_CHECKING, Iterable, Mapping, Optional, Sequence, Union

from pandas import DataFrame
from tabulate import tabulate

from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
from airflow.hooks.dbapi import DbApiHook
from airflow.models import BaseOperator
from airflow.providers.slack.hooks.slack_webhook import SlackWebhookHook

if TYPE_CHECKING:
from airflow.utils.context import Context


class SqlToSlackOperator(BaseOperator):
"""
Executes an SQL statement in a given SQL connection and sends the results to Slack. The results of the
query are rendered into the 'slack_message' parameter as a Pandas dataframe using a JINJA variable called
'{{ results_df }}'. The 'results_df' variable name can be changed by specifying a different
'results_df_name' parameter. The Tabulate library is added to the JINJA environment as a filter to
allow the dataframe to be rendered nicely. For example, set 'slack_message' to {{ results_df |
tabulate(tablefmt="pretty", headers="keys") }} to send the results to Slack as an ascii rendered table.

.. seealso::
For more information on how to use this operator, take a look at the guide:
:ref:`howto/operator:SqlToSlackOperator`

:param sql: The SQL statement to execute on Snowflake (templated)
:param slack_message: The templated Slack message to send with the data returned from Snowflake.
You can use the default JINJA variable {{ results_df }} to access the pandas dataframe containing the
SQL results
:param sql_conn_id: Reference to
:ref:`Snowflake connection id<howto/connection:snowflake>`
:param slack_conn_id: The connection id for Slack. Mutually exclusive with 'slack_webhook_token'
:param slack_webhook_token: The token to use to authenticate to Slack. If this is not provided, the
'slack_conn_id' attribute needs to be specified in the 'Extra' JSON field.
Mutually exclusive with 'slack_conn_id'.
:param slack_channel: The channel to send message. Override default from Slack connection.
:param results_df_name: The name of the JINJA template's dataframe variable, default is 'results_df'
:param parameters: The parameters to pass to the SQL query
"""

template_fields: Sequence[str] = ('sql', 'slack_message')
template_ext: Sequence[str] = ('.sql', '.jinja', '.j2')
template_fields_renderers = {"sql": "sql", "slack_message": "jinja"}
times_rendered = 0

def __init__(
self,
*,
sql: str,
sql_conn_id: str,
slack_conn_id: Optional[str] = None,
slack_webhook_token: Optional[str] = None,
slack_channel: Optional[str] = None,
slack_message: str,
results_df_name: str = 'results_df',
parameters: Optional[Union[Iterable, Mapping]] = None,
**kwargs,
eladkal marked this conversation as resolved.
Show resolved Hide resolved
) -> None:

super().__init__(**kwargs)

self.sql_conn_id = sql_conn_id
self.sql = sql
self.parameters = parameters
self.slack_conn_id = slack_conn_id
self.slack_webhook_token = slack_webhook_token
self.slack_channel = slack_channel
self.slack_message = slack_message
self.results_df_name = results_df_name
self.kwargs = kwargs

if not self.slack_conn_id and not self.slack_webhook_token:
raise AirflowException(
"SqlToSlackOperator requires either a `slack_conn_id` or a `slack_webhook_token` argument"
)

if self.slack_conn_id and self.slack_webhook_token:
raise AirflowException("Cannot pass both `slack_conn_id` and `slack_webhook_token` arguments")

def _get_hook(self) -> DbApiHook:
self.log.debug("Get connection for %s", self.sql_conn_id)
conn = BaseHook.get_connection(self.sql_conn_id)
hook = conn.get_hook(hook_params=self.kwargs)
if not callable(getattr(hook, 'get_pandas_df', None)):
raise AirflowException(
"This hook is not supported. The hook class must have get_pandas_df method."
)
return hook

def _get_query_results(self) -> DataFrame:
sql_hook = self._get_hook()

self.log.info('Running SQL query: %s', self.sql)
df = sql_hook.get_pandas_df(self.sql, parameters=self.parameters)
return df

def _render_and_send_slack_message(self, context, df) -> None:
# Put the dataframe into the context and render the JINJA template fields
context[self.results_df_name] = df
self.render_template_fields(context)

slack_hook = self._get_slack_hook()
self.log.info('Sending slack message: %s', self.slack_message)
slack_hook.execute()

def _get_slack_hook(self) -> SlackWebhookHook:
if self.slack_conn_id:
return SlackWebhookHook(
http_conn_id=self.slack_conn_id, message=self.slack_message, channel=self.slack_channel
)
elif self.slack_webhook_token:
return SlackWebhookHook(
message=self.slack_message, webhook_token=self.slack_webhook_token, channel=self.slack_channel
)
else:
raise AirflowException("Could not initiate SlackWebhookHook")

def render_template_fields(self, context, jinja_env=None) -> None:
# If this is the first render of the template fields, exclude slack_message from rendering since
# the snowflake results haven't been retrieved yet.
if self.times_rendered == 0:
fields_to_render: Iterable[str] = filter(lambda x: x != 'slack_message', self.template_fields)
else:
fields_to_render = self.template_fields

if not jinja_env:
jinja_env = self.get_template_env()

# Add the tabulate library into the JINJA environment
jinja_env.filters['tabulate'] = tabulate

self._do_render_template_fields(self, fields_to_render, context, jinja_env, set())
self.times_rendered += 1

def execute(self, context: 'Context') -> None:
if not isinstance(self.sql, str):
raise AirflowException("Expected 'sql' parameter should be a string.")
if self.sql is None or self.sql.strip() == "":
raise AirflowException("Expected 'sql' parameter is missing.")
if self.slack_message is None or self.slack_message.strip() == "":
raise AirflowException("Expected 'slack_message' parameter is missing.")

df = self._get_query_results()
self._render_and_send_slack_message(context, df)

self.log.debug('Finished sending SQL data to Slack')
Loading