Refactor DR.task_instance_scheduling_decisions #24774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved the part that sets 'ti.task' from _find_missing_task_indexes out to task_instance_scheduling_decisions. When tracing the code around here, it was difficult for me to realize the inner _find function actually modifies the 'task' attribute. This makes things more obvious to read. Also added some simple type hints.
uranusjr
force-pushed
the
dag-run-task-population-refactor
branch
from
e46f030
to
f5f4356
Compare
ephraimbuddy
approved these changes
Jul 1, 2022
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2022
(cherry picked from commit 5d5d62e)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the part that sets
ti.taskfrom_find_missing_task_indexesout totask_instance_scheduling_decisions. When tracing the code around here, it was difficult for me to realize the inner _find function actually modifies thetaskattribute. This makes things more obvious to read.Also added some simple type hints.