Add blocksize arg for ftp hook #24860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevgeo
changed the title
|
Makes sense, but please fix the errors. (Documentation failure is unrelated and can be ignored for now.) |
potiuk
force-pushed
the
add_blocksize_arg_ftphook
branch
from
19f8760
to
c8421af
Compare
kevgeo
force-pushed
the
add_blocksize_arg_ftphook
branch
from
c8421af
to
343bc74
Compare
potiuk
approved these changes
Jul 7, 2022
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: issue #23935 to add blocksize as an argument to transfer files from ftp server to local machine in user-defined chunks.
I have also added blocksize as an argument to store_file() which transfers from local machine to ftp server as it is useful too.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst, in newsfragments.