Upgrade FAB to 4.1.3 #24884
Upgrade FAB to 4.1.3 #24884
Conversation
|
You can't update constraints in the same PR because constraints are in orphaned branch (constraints-main). The Constraints main should be refreshed at merge time via https://github.com/apache/airflow/blob/main/dev/REFRESHING_CI_CACHE.md#manually-generating-constraint-files This is only really needed when you have the == change (or otherwise chagne that introduces range of dependency that does not overlap with the previous range). This is the only case that is not (yet) handled automatically (it could be, but we would have to create a PR automatically to the Effectively it means that the person (committer) who merges it, should prepare constraints just before merge and do the push at the same time as merge (either way it needs a bit synchronized action). You cannot push to the branch as you are not a committer. |
|
thanks for the explanation @potiuk |
no relevant changes found when comparing `airflow/www/fab_security` with FAB see dpgaspar/Flask-AppBuilder@v4.1.2...v4.1.3
|
BTW. I rebased it so that I can merge it tomorrow morning - I just merged a bit "bigger" requirement change (moving SQL classes to a new provider). So I want to make sure this one is run on -top of it. |
|
But actually, you made me think - this is a good idea to bring such changes in a form of PR even if it's not automated yet. |
|
Linked PR with constraints: #24886 |
|
Both merged. |
no relevant changes found when comparing `airflow/www/fab_security` with FAB see dpgaspar/Flask-AppBuilder@v4.1.2...v4.1.3 (cherry picked from commit 01a5d8f)
no relevant changes found when comparing `airflow/www/fab_security` with FAB see dpgaspar/Flask-AppBuilder@v4.1.2...v4.1.3 (cherry picked from commit 01a5d8f)
no relevant changes found when comparing `airflow/www/fab_security` with FAB see dpgaspar/Flask-AppBuilder@v4.1.2...v4.1.3 (cherry picked from commit 01a5d8f)
ephraimbuddy
added
the
type:misc/internal
No relevant changes were found when comparing
airflow/www/fab_securitywith the FAB source.See dpgaspar/Flask-AppBuilder@v4.1.2...v4.1.3
Ps.: I think that the constraints-main file needs to be updated somehow. Let me know if I need to handle this on that same PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.