No grid auto-refresh for backfill dag runs #25042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingxuanwangxuan
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
|
what is this error，can you help me, thanks. |
|
HI @yingxuanwangxuan, can you an explanation in the PR description of what's being fixed and how this PR resolves the issue. It's not entirely clear without a description or a linked issue. |
|
Issue: #24844 Not sure about the CI failure. I'd say rebase the branch and see if it persists. |
bbovenzi
changed the title
bbovenzi
approved these changes
Jul 20, 2022
|
Awesome work, congrats on your first merged pull request! |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2022
* Update useGridData.ts * Update useGridData.test.js * Update useGridData.test.js (cherry picked from commit de6938e)
53 tasks
cloventt
reviewed
Aug 25, 2022
| @@ -49,7 +49,7 @@ const emptyGridData: GridData = { | |||
| }, | |||
| }; | |||
|
|
|||
| export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0; | |||
| export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['manual', 'manual'].includes(run.runType)).filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0; | |||
There was a problem hiding this comment.
Surely this should be:
export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['scheduled', 'manual'].includes(run.runType)).filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;There was a problem hiding this comment.
thanks for fix this. @bbovenzi can you review it again?
This was referenced Aug 25, 2022
cloventt
added a commit
to cloventt/airflow
that referenced
this pull request
Aug 25, 2022
In PR apache#25042 the merged change included a bug that prevents the page from auto-refreshing if there are anything other than manual runs on the page. We also want to auto-refresh for scheduled runs. I've also added more complete unit tests for the expected behaviour.
potiuk
pushed a commit
that referenced
this pull request
Aug 25, 2022
In PR #25042 the merged change included a bug that prevents the page from auto-refreshing if there are anything other than manual runs on the page. We also want to auto-refresh for scheduled runs. I've also added more complete unit tests for the expected behaviour.
ephraimbuddy
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 25, 2022
In PR apache#25042 the merged change included a bug that prevents the page from auto-refreshing if there are anything other than manual runs on the page. We also want to auto-refresh for scheduled runs. I've also added more complete unit tests for the expected behaviour. (cherry picked from commit 37ec752)
2 tasks
Gollum999
added a commit
to Gollum999/airflow
that referenced
this pull request
Sep 18, 2022
This reverts commit de6938e.
bbovenzi
pushed a commit
that referenced
this pull request
Sep 21, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run auto-refresh for backfill dag runs.
Closes: #24844
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.