Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Authentication to webhdfs sensor #25110

Merged
merged 25 commits into from
Jul 19, 2022

Conversation

ankurbajaj9
Copy link
Contributor

@ankurbajaj9 ankurbajaj9 commented Jul 16, 2022

Addition of authentication in case password is provided


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@ankurbajaj9 ankurbajaj9 marked this pull request as ready for review July 18, 2022 09:56
@ankurbajaj9
Copy link
Contributor Author

The code had no authentication statement till now. I'm not sure if it was only being used in unauthenticated enviornments.

@potiuk
Copy link
Member

potiuk commented Jul 18, 2022

Can you please update the description/name of the commit/PR and add tests covering this functionality @ankurbajaj9 ?

@ankurbajaj9 ankurbajaj9 changed the title Bugfix/optional port Adding Authentication to webhdfs sensor Jul 18, 2022
@potiuk
Copy link
Member

potiuk commented Jul 18, 2022

Static checks need fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants