Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQSPublishOperator should allow sending messages to a FIFO Queue #25171

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

dbarrundiag
Copy link
Contributor

This PR closes: #25138.

Changes:

  • New attribute of message_group_id in SQSPublishOperator to support sending that value to the AWS APIs when the SQS queue is a FIFO queue.
  • 2 new test cases
    • If the parameter MessageGroupId is not provided and the Operator attempts to send a message to a FIFO queue, the Operator will fail.
    • If the parameter MessageGroupId is provided and the Operator attempts to send a message to a FIFO queue, the Operator should succeed and the MessageGroupId should come in the response.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Jul 19, 2022
@dbarrundiag
Copy link
Contributor Author

CC: @eladkal - closed #25170 in favor of this one

@dbarrundiag
Copy link
Contributor Author

@eladkal @potiuk - do you guys know if we can "rerun" these Static checks.

From what I can tell Github Actions failed on the run-shellcheck check:
Screen Shot 2022-07-19 at 10 54 37 PM

however i think this might have been a transient issue because the checks are passing locally:
Screen Shot 2022-07-19 at 10 51 43 PM

@potiuk
Copy link
Member

potiuk commented Jul 20, 2022

Just re-run - it.. Question @dbarrundiag Do you have the ability to re-run yourself (top rigth when you go to details?)

@dbarrundiag
Copy link
Contributor Author

Just re-run - it.. Question @dbarrundiag Do you have the ability to re-run yourself (top rigth when you go to details?)

Screen Shot 2022-07-20 at 7 04 33 AM

@potiuk no i believe i am not able to re-run it, unless i am completely missing something

@potiuk
Copy link
Member

potiuk commented Jul 21, 2022

@potiuk no i believe i am not able to re-run it, unless i am completely missing something

Yeah. I've learned today that partial re-run from https://github.blog/2022-03-16-save-time-partial-re-runs-github-actions/ is only available to maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQSPublishOperator should allow sending messages to a FIFO Queue
2 participants