-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth_type to LivyHook #25183
Add auth_type to LivyHook #25183
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdsoha Thanks for PR! It's really a great day when you see a first-time contribution the Airflow project. WDYT about exposing this parameter in the Livy operator and sensor so other users can configure an auth_type
when using those modules in their DAGs?
Would you mind including this new parameter in the relevant unit tests as well?
I will include those updates, as well as unit-tests and docblocks. |
You should add unit tests covering it. |
@bdsoha are you still working on this PR? It's missing tests to cover the new functionality. |
@eladkal added unit tests |
Just in time for new provider's release. |
But some fixes are needed @bdsoha if you want to make it on time (tomorrow) |
Awesome work, congrats on your first merged pull request! |
Merged! 🎉 |
Closes: #25179