Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth_type to LivyHook #25183

Merged
merged 7 commits into from
Aug 7, 2022
Merged

Add auth_type to LivyHook #25183

merged 7 commits into from
Aug 7, 2022

Conversation

bdsoha
Copy link
Contributor

@bdsoha bdsoha commented Jul 20, 2022

Closes: #25179

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 20, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdsoha Thanks for PR! It's really a great day when you see a first-time contribution the Airflow project. WDYT about exposing this parameter in the Livy operator and sensor so other users can configure an auth_type when using those modules in their DAGs?

Would you mind including this new parameter in the relevant unit tests as well?

@bdsoha
Copy link
Contributor Author

bdsoha commented Jul 21, 2022

I will include those updates, as well as unit-tests and docblocks.

@potiuk
Copy link
Member

potiuk commented Jul 21, 2022

You should add unit tests covering it.

@eladkal
Copy link
Contributor

eladkal commented Aug 6, 2022

@bdsoha are you still working on this PR? It's missing tests to cover the new functionality.

@bdsoha
Copy link
Contributor Author

bdsoha commented Aug 7, 2022

@eladkal added unit tests

@potiuk
Copy link
Member

potiuk commented Aug 7, 2022

Just in time for new provider's release.

@potiuk
Copy link
Member

potiuk commented Aug 7, 2022

But some fixes are needed @bdsoha if you want to make it on time (tomorrow)

@bdsoha
Copy link
Contributor Author

bdsoha commented Aug 7, 2022

@potiuk The current workflow is failing for Tests / Postgres10,Py3.7 downgrade step. This step passed on the previous execution 48fbd89. No code changes (only style) were added to the current commit.

@potiuk
Copy link
Member

potiuk commented Aug 7, 2022

@potiuk The current workflow is failing for Tests / Postgres10,Py3.7 downgrade step. This step passed on the previous execution 48fbd89. No code changes (only style) were added to the current commit.

Yep. Re-run it . Looked like an intermittent issue.

@potiuk potiuk merged commit 7d3e799 into apache:main Aug 7, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 7, 2022

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Aug 7, 2022

Merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auth_type to LivyHook
5 participants