Add dev version of asset compilation #25272
Conversation
potiuk
force-pushed
the
add-dev-www-compilation
branch
2 times, most recently
from
0ee2cf7
to
443e14a
Compare
potiuk
force-pushed
the
add-dev-www-compilation
branch
from
253a104
to
07f82bf
Compare
potiuk
force-pushed
the
add-dev-www-compilation
branch
from
07f82bf
to
2431a1e
Compare
|
BTW. @bbovenzi @pierrejeambrun - one comment, the nice thing about using pre-commit is that you do not have to care about maintaining your 'node + yarn' in the right version, so it will be always "working the same" for everyone using But the problem with pre-commit is that it captures the outpt and only shows it (even in verbose mode) after it completes, but in this case - it will never complete :) - so you do not see the output of the compiled assets as they change (which I find is a good "sanity check" to see that things are atually being refreshed. You will see it in |
potiuk
force-pushed
the
add-dev-www-compilation
branch
3 times, most recently
from
ceb3654
to
18a5381
Compare
|
I wonder if we should add something to the message here so that developers know that its actively running and not stuck? |
|
Yeah, why not. |
When we moved www asset compilation from container to the host in apache#25169, we removed yarn from the image and the old instructions are no longer valid. Instead of in-container yarn dev we expect now to have yarn dev run in the host. It can be done either with pre-commit (if you have no node/yarn installed in your host, pre-commit will automatically install both node and yarn in the right versions, or if you have yarn installed you can run it manually. The 'start-airflow' instructions now remove the in-container instructions and explain those two options you have.
potiuk
force-pushed
the
add-dev-www-compilation
branch
from
18a5381
to
3e374dc
Compare
|
How about this 😛 @bbovenzi ?
|
When we moved www asset compilation from container to the host in #25169, we removed yarn from the image and the old instructions are no longer valid. Instead of in-container yarn dev we expect now to have yarn dev run in the host. It can be done either with pre-commit (if you have no node/yarn installed in your host, pre-commit will automatically install both node and yarn in the right versions, or if you have yarn installed you can run it manually. The 'start-airflow' instructions now remove the in-container instructions and explain those two options you have. (cherry picked from commit 1544868)
ephraimbuddy
added
the
changelog:skip
When we moved www asset compilation from container to the host in #25169,
we removed yarn from the image and the old instructions are no longer
valid. Instead of in-container yarn dev we expect now
to have yarn dev run in the host. It can be done either with
pre-commit (if you have no node/yarn installed in your host, pre-commit
will automatically install both node and yarn in the right versions,
or if you have yarn installed you can run it manually.
The 'start-airflow' instructions now remove the in-container
instructions and explain those two options you have.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.