Remove useless logging line #25347
Merged
Remove useless logging line #25347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eladkal is this still on time for Airflow |
potiuk
approved these changes
Jul 27, 2022
|
That was quick, even for you @potiuk :p |
|
For 2.4.0 for sure - we have not yet cut the branch for 2.4. I will mark it for 2.3.4 in case we have it, but it's not very likely I think ( we will go straight to 2.4.0 with all bugfixes most likely - but it's up to @jedcunningham and @ephraimbuddy to decided.). |
jedcunningham
approved these changes
Jul 27, 2022
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
ephraimbuddy
added
type:improvement
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2022
(cherry picked from commit 5efe6f3)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently more than 50% of our scheduler logs are in the form of
Failed to get task ... Marking it as removed.There are two of these logging lines in this file, one already has this if else statement, the other one was missing it.
This should considerably bring down logging messages for airflow instances where the
taskschange a lot while using the same dag.