Fix reducing mapped length of a mapped task at runtime after a clear #25531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norm
reviewed
Aug 4, 2022
norm
reviewed
Aug 4, 2022
ashb
reviewed
Aug 4, 2022
The previous fix on task immutability after a run did not fix a case where the task was removed at runtime when the literal is dynamic. This PR addreses it
ephraimbuddy
force-pushed
the
fix-dynamic-task-immutability
branch
from
72f13a0
to
3a1bef7
Compare
ephraimbuddy
force-pushed
the
fix-dynamic-task-immutability
branch
from
3a1bef7
to
b787390
Compare
norm
approved these changes
Aug 4, 2022
uranusjr
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix on task immutability after a run did not fix a case where the task was removed at runtime when the literal is dynamic. This PR addreses it
There's still a case which I haven't figured out yet. Reducing the length thereby marking the task instance as removed and then increasing the length to equal the original length or more. This still leaves the removed task instance as removed