Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grid task row scrollbar overlapping on Firefox #25554

Merged

Conversation

pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Aug 5, 2022

Fixes: #25512

As suggested by @bbovenzi, we just add a small right padding to not have overlapping between the scrollbar and the content.

On Chrome
image

On FireFox
image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 5, 2022
@pierrejeambrun pierrejeambrun changed the title Fix Grid task row scrollbar on Firefox Fix Grid task row scrollbar overlapping on Firefox Aug 5, 2022
@potiuk
Copy link
Member

potiuk commented Aug 5, 2022

The usual fun

image

@bbovenzi bbovenzi merged commit fe97729 into apache:main Aug 5, 2022
@pierrejeambrun pierrejeambrun deleted the 25512-fix-task-rows-scroll-bar-firefox branch August 5, 2022 16:47
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Aug 15, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.4 milestone Aug 15, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
(cherry picked from commit fe97729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical overlay scrollbar on Grid view blocks last DAG run column
4 participants