Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the custom secrets backend so the same instance gets re-used #25556

Merged
merged 3 commits into from
Aug 6, 2022
Merged

Cache the custom secrets backend so the same instance gets re-used #25556

merged 3 commits into from
Aug 6, 2022

Commits on Aug 5, 2022

  1. Cache the custom secrets backend so the same instance gets re-used 

    Fixes apache#25555

This uses `functools.lru_cache` to re-use the same secrets backend
instance between the `conf` global when it loads configuration from
secrets and uses outside the `configuration` module like variables and
connections. Previously, each fetch of a configuration value from
secrets would use its own secrets backend instance.
    @pdebelak
    pdebelak committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    cade498 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Add secrets backend kwargs to cache key 

    Also add unit test to confirm that only one secrets backend instance
gets created.
    @pdebelak
    pdebelak committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    9097b53 View commit details
    Browse the repository at this point in the history

  2. Set maxsize for cache on _custom_secrets_backend

    @pdebelak
    pdebelak committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    db6b8ab View commit details
    Browse the repository at this point in the history