-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable umask to all deamonized processes. #25664
Conversation
We previously had this for just the `celery worker` subcommand, this PR extends it to anything that can run in daemon mode
@@ -671,7 +671,6 @@ def string_lower_type(val): | |||
ARG_UMASK = Arg( | |||
("-u", "--umask"), | |||
help="Set the umask of celery worker in daemon mode", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help needs updating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not currently -- it's only used for the celery worker
command -- the other commands don't have a --umask
argument, they only use the config value.
We previously had this for just the `celery worker` subcommand, this PR extends it to anything that can run in daemon mode (cherry picked from commit bf14d14)
We previously had this for just the
celery worker
subcommand, this PRextends it to anything that can run in daemon mode.
The old celery.worker_umask is still respected, but not shown in the config anymore.