-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQL split string to include ;-less
statements
#25713
Conversation
e77b396
to
2c9c098
Compare
2c9c098
to
b73e910
Compare
@kazanzhy @alexott - I chose a little different approach than proposed in #25640 (comment) - after adding unit tests. I generaly filter out all empty statements during the split - that will even allow comment-only statements for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry for being offline. I tried to work on #25259 finally. Initially, I took this code from the drill provider where it was like:
which is the like current I tested it with different queries and even with comments and I see that I really missed the query like |
There was a bug in an incoming change to common-sql provider introduced in apache#23971 where `;-less` statements were removed when "split_statements" flag was used. Since this flag is used by default in Databricks statement, it introduced backwards incompatible change.
b73e910
to
1224477
Compare
I think this one should be ready to review :). |
There was a bug in an incoming change to common-sql provider
introduced in #23971 where
;-less
statements were removedwhen "split_statements" flag was used. Since this flag is used
by default in Databricks statement, it introduced backwards
incompatible change.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.