Add backward compatibility with old versions of Apache Beam #27263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:Apache
provider:google
|
@mik-laj LGTM |
potiuk
approved these changes
Oct 31, 2022
potiuk
approved these changes
Oct 31, 2022
|
Tests failing though |
mik-laj
force-pushed
the
beam-old-versions
branch
3 times, most recently
from
16f5d3f
to
5420b28
Compare
potiuk
force-pushed
the
beam-old-versions
branch
from
5420b28
to
7e91f92
Compare
|
Rebased- I have fixed the "backtracking" issue in main (some newly released dependencies caused back-tracking of pip resolver), so it should not fail this time. |
Adityamalik123
pushed a commit
to Adityamalik123/airflow
that referenced
this pull request
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #23961 added support for impersonation of service accounts, but at the same time limited the supported versions of Apache Beam to 2.39.0. This is a very big limitation considering that this functionality is not critical and many existing pipelines require an older version. On the other hand, this restriction is not checked if the user installs beam in a separate virtual environment. On the other hand, this restriction is not checked if the user installs beam in a separate virtual environment. Then Apache Beam starts, but unsupported options are passed.
To solve these two problems, I moved the Apache Beam version check to runtime and use the old version restrictions in
providers.yaml.Additionally, I will unblock the work on Snowpark integration which requires
cloudpickle2.0.0 while Apache Beam 2.39.0 requirescloudpickle2.1.0.CC: @lwyszomi
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.